renaming
samoht opened this issue · 8 comments
Would it be possible to:
- rename the repository to
charrua - rename the core library to
charrua
Not sure that -core is needed anymore. WDYT?
I have no opinion on the name (and will not rename the package myself), but I strongly desire that anyone who renames it also handles the renaming for reverse dependencies, submits the necessary pull requests to opam-repository, and handles the change in the mirage front-end tool.
Aw, c'mon. charrua-core is like normcore or thrashcore or hardcore, but better. It makes total sense.
Also I'd like the renaming to make 1.0, where charrua-client would be also merged into charrua-dhcp, as Dhcp_client (lib/client.ml), so that it becomes symetrical with the server.
what do you think @yomimono ?
I have no opinion on the name (and will not rename the package myself), but I strongly desire that anyone who renames it also handles the renaming for reverse dependencies, submits the necessary pull requests to opam-repository, and handles the change in the mirage front-end tool.
Renaming the package will break compatibility and so makes sense to do at version 1.0.
now 1.5 years passed, and there has been lots of activity on this repository... I'm in favour of fixing this issue, but am not entirely sure what the best way forward is, here's my proposal:
- repository should be
charrua - move the
serverlogic (dhcp_server.ml) be moved to aserverdirectory (providingcharrua-server-- a separate opam package and ocamlfind lib) - move the dhcp config file parser to another opam package (parser? config?) and separate directory
now, since it's rather convenient (due to lack of namespacing) in ocaml/opam to use the opam package name as prefix of the modules, I'd also be in favour of renaming the modules in here:
- lib/dhcp_wire to lib/charrua
- etc.
any opinion on this? if not (or positive), I'd try to open a PR that accomplishes the stuff mentioned above, and we can see whether you like it or not.