mit6005/S13-R08-12noon-indigo

Issues

• In the Instrument enum: I think STEAL_DRUMS should be STEEL_DRUMS

  #12 opened 12 years ago
  1

• Concat should have a getter method 'second' that returns the second music (like 'first' returns first)

  #11 opened 12 years ago
  1

• Note has a rep invariant that pitch is not null, but Note.checkRep doesn't assert that, it should

  #10 opened 12 years ago
  1

• Concat.checkRep is not implemented, it's supposed to check that first and second are not null

  #9 opened 12 years ago
  1

• Note.equals returns true if we call it with null; should be false!

  #8 opened 12 years ago
  1

• The Note.testNote method was just for testing, it should be removed

  #7 opened 12 years ago
  2

• Pitch.difference is backwards, subtraction needs to be reversed in order to return the specified value

  #6 opened 12 years ago
  2

• Concat.duration returns the wrong value, only looks at the first music duration, should be the sum

  #5 opened 12 years ago
  0

• Rest doesn't compile, missing duration method!

  #4 opened 12 years ago
  1

• Pitch has the wrong value for OCTAVE, there are 12 semitones in an octave

  #3 opened 12 years ago
  1

• SequencePlayer.main doesn't compile, needs to throw MidiUnavailableException and InvalidMidiDataException

  #2 opened 12 years ago
  1

• SequencePlayer.main test scale ends with the wrong note, should be C

  #1 opened 12 years ago
  1