mkoryak/floatThead

"InternalError: too much recursion" in Firefox during print

williammck opened this issue · 14 comments

williammck commented

Hi! I noticed that when printing in Firefox, InternalError: too much recursion is thrown twice, at the beforeprint and afterprint events. Printing still works fine, but only after about a second of delay once the JS engine stops the infinite recursion.

It's happening here: https://github.com/mkoryak/floatThead/blob/master/src/jquery.floatThead.js#L139, as triggerHandler then again calls the handlers set in that if statement.

This isn't personally causing me an issue (other than filling up my Sentry logs), but I'd imagine for sites with some functionality in the before/after print handlers it could create some trouble.

Reproduction URL: https://mkoryak.github.io/floatThead/ (it occurs on any normal install of floatThead from what I can tell)

Browser: Firefox 59
OS: Windows 10, macOS 10.13
jQuery version: 3.3.1 (latest)
floatThead version: 2.1.1 (latest)

mkoryak commented
  • 👍1
williammck commented

Quick update: am seeing it happening now all the way back to FF47 on macOS 10.11.

I guess one way to fix it is to have a printing variable, check for false and set to true in beforeprint, then check for true and set to false in afterprint

No problem about the logs - wouldn't have known this was happening otherwise! :)

mkoryak commented

I cannot do what I promised, no time lately. Pull requests are welcome :)
Otherwise, ill get to it as soon as I get to it.

williammck commented
mkoryak commented

should be fixed in /src, let me know how bad you want a release :)

williammck commented

whenever! I don't really care, been super busy moving house.

just put it in with whatever next release, we're in education so our product won't see much usage until fall.

williammck commented

our product won't see much usage until fall

aaand, right on time, I've started getting reports of the issue again.

any chance you're rolling a new release in the near future? would greatly appreciate it. :)

mkoryak commented

Sure thing, I'm away until Tuesday. Expect a release around that time.

williammck commented

hey! sorry if you're busy, just checking back in about when to expect a release :)

mkoryak commented

good question. Got busy at work. Next week?

williammck commented

Sure! It's not happening a ton, just got another bug report of it and it reminded me. Take your time if needed.

mkoryak commented

Ok, that took forever, but finally I published it as 2.1.3

williammck commented

Much appreciated! 😄

lock commented

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.