TypeScript Definitions
jmariller opened this issue · 6 comments
jmariller commented
Hello,
Would it be possible to add TypeScript definitions for this library? I find floatThead really great, the only thing missing would be those definitions.
Many thanks!
mkoryak commented
Pull requests are welcome!
I think I saw something for it in DefinitelyTyped
…On Tue, May 19, 2020, 5:19 PM jmariller ***@***.***> wrote:
Hello,
Would it be possible to add TypeScript definitions for this library? I
find floatThead really great, the only thing missing would be those
definitions.
Many thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#457>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC5WSPAXBEZID3KR4EV4FDRSLZUHANCNFSM4NFLQ76Q>
.
jmariller commented
Done, please see #458.
Most of the credit should go to @InkUisitor who had posted a proposal in DefinitelyTypes which I used as basis for the PR.
mkoryak commented
I took a closer look to the TS defs, and they looked incorrect. I made an update, can you check if they work or if my bad typescript knowledge is wrong:
jmariller commented
Thanks for the update - your adjustments are fine!
Two more things:
- I picked up the wrong attribute for
package.jsonto point at TypeScript definitions file 🤦♂️ sorry about that. It'stypes, nottype- opened a new PR, see #460. - I believe you need to run
buildonce so the definition file gets copied intodist
PS: cool name for the latest release 😄
mkoryak commented
Published 2.2.1. Let me know if it works.
jmariller commented
Works fine now, thank you very much!