mmoreram/ControllerExtraBundle

v1.1.5 has a dependency on a non-existent service "request_stack"

Closed this issue · 3 comments

i use symfony 2.3 and for composer the version 1.1.5 is listed as 2.3 compatible, however, wen ive just finished implementing some custom annotation i had this surprise exception.

request_stack is a symfony 2.4 feature, maybe you should fix the composer.json for this version.

@jhonatanTeixeira wow, you're right, thanks!

This is a Big BCBreak, so heavy! I need to think how to fix it...

  • I make the library compatible minimum with 2.4 ( Symfony uses semver, so you could go to 2.* without BC Break )
  • I fix the issue, so I have to change the public API.

Let me think about it please :)

At least u've made it extensible, i managed a workaround by extending the service and overriding it, i really liked this bundle

Thanks a lot :)

Could you please share your overrides? Maybe we could use them as the default implementation, and fix this issue :)