moisseev/rspamd-spamness

Firefox 60.3.1 32bit and 64bit

Closed this issue · 19 comments

thorstencoordes commented

My e-mails are marked with X-Spam-Score and X-Spam-Status, but it is not shown in the Spam score [Rspamd] column. I repaired the folder, restarted Firefox, but nothing is shown. Also played with the options under Settings with visual, score, ... no effect. I am using Thunderbird 60.3.1 and I have both 32bit and 64bit installed.

Regards,
TC

moisseev commented

Are you using Rspamd with Exim? Can you post some samples of the headers?

thorstencoordes commented
moisseev commented

Thank you for the sample. The headers looks like SpamAssassin headers. SpamAssassin headers are not supported by this add-on. For SpamAssassin you need to use original Spamness add-on.

nyarlatothep commented

Hi there.
The original Spamness add-on is only supported up to thunderbird 21.
Would it be possible to add an option to you rspamd-spamness so it can use other (spamassassin) headers?
I'm looking desperately for a way to show a spamscore in a column. All old addons don't work anymore (neither column wizard or spamness).

Would be nice to have an option like my Spam-Header: 'X-MyOwn-MailScanner-SpamCheck'
and it simply shows the value after the word 'score' in this header.

Maybe it's just an easy tweak of your addon. If not, just ignore my posting. :)

Thanks for your time,
regards,
nyar

moisseev commented

The original Spamness add-on is only supported up to thunderbird 21.

BTW, It is highly likely that Thunderbird 60.* will be the last version supported by Rspamd-spamness.

I'm looking desperately for a way to show a spamscore in a column. All old addons don't work anymore (neither column wizard or spamness).

Would be nice to have an option like my Spam-Header: 'X-MyOwn-MailScanner-SpamCheck'
and it simply shows the value after the word 'score' in this header.

@nyarlatothep Would X-Spam-Score header work for you? Do you actually need support for configurable header name?

nyarlatothep commented

BTW, It is highly likely that Thunderbird 60.* will be the last version supported by Rspamd-spamness.
Uh, oh,... :(

@nyarlatothep Would X-Spam-Score header work for you? Do you actually need support for configurable header name?
Actually, yes. Because depending on the the installed mail-system my header differs:

One of my old system shows (based on amavis-new with spamassassin):
X-Spam-Score: 12.559
X-Spam-Level: ************
X-Spam-Status: Yes, score=12.559

a new one will be more like (based on mailscanner with spamassassin):
X-ORG-MailScanner-SpamScore: sssssss
X-ORG-MailScanner-SpamCheck: spam, SpamAssassin (not cached, score=7.406,

I thought with some options for different headers a lot more people will be happy. But i guess it gets a lot more complicated to implement, drifting to an universal spamness-addon.

Thanks for getting in touch with me,
nyar

moisseev commented

@nyarlatothep It should work now for both of your systems if you enter X-ORG-MailScanner-SpamCheck header in the advanced options.

nyarlatothep commented

@moisseev
Oh my.. Will try out next week. Never thought this will happen.
If this work, i think a lot more people will be happy to hear, it should be mentioned on the addon-page itself. Btw., where to download the new version? Hope it will be downloadable by the next week.

Thanks for your work and time, great stuff!
nyar

moisseev commented

@nyarlatothep You don't have to wait for release. An XPI file is simply a ZIP file, containing the add-on files. You can just download source files from GitHub and repack them so they are located at the root of the ZIP. Like this: add-on.zip
Then you can rename it to .xpi or just drag and drop as is to Add-ons Manager tab.

Any help in testing would be appreciated.

thorstencoordes commented
nyarlatothep commented

Any help in testing would be appreciated.

Works great for my first setting with
X-Spam-Score: 12.559

Sadly, i can't get it to work with my second system. I put X-ORG-MailScanner-SpamCheck into the advanced option, but the column doesn't show any number. Tried several repairs of the folder.
I use multiple accounts in thunderbird, one account using the X-Spam-Score the other accounts X-ORG-MailScanner-SpamCheck. Does it matter?

Is it case-sensitive? Because when i check the advanced option for a second time it has been converted to lower letters: x-org-mailscanner-spamcheck

Does the addon extract the number from the second line? (the number after the score part)
X-ORG-MailScanner-SpamScore: sssssss
X-ORG-MailScanner-SpamCheck: spam, SpamAssassin (not cached, score=7.589, required 4, BAYES_99 3.50, BAYES_999 0.20, FREEMAIL_FORGED_REPLYTO 2.10, HTML_MESSAGE 0.00, KAS_SPAM_DNSBL_NIX 1.00, RDNS_NONE 0.79)

Because the new system shows "s" in the SpamScore (for using sieve for filtering), so the only available number is in the second line, hidden in the long text.

Thanks again for your effort, will try further. If i can be of any help, let me know.
nyar

moisseev commented

Sadly, i can't get it to work with my second system. I put X-ORG-MailScanner-SpamCheck into the advanced option, but the column doesn't show any number. Tried several repairs of the folder.
I use multiple accounts in thunderbird, one account using the X-Spam-Score the other accounts X-ORG-MailScanner-SpamCheck. Does it matter?

No, it should work for multiple accounts.

Is it case-sensitive?

No, headers names are converted to lower case before matching.

Does the addon extract the number from the second line? (the number after the score part)
X-ORG-MailScanner-SpamScore: sssssss
X-ORG-MailScanner-SpamCheck: spam, SpamAssassin (not cached, score=7.589, required 4, BAYES_99 3.50, BAYES_999 0.20, FREEMAIL_FORGED_REPLYTO 2.10, HTML_MESSAGE 0.00, KAS_SPAM_DNSBL_NIX 1.00, RDNS_NONE 0.79)

I've tried this sample and the add-on extracts the score. For now it is broken if multiple additional headers are specified, but for one header it should work.

The add-on looks for a header in the message until it finds a matched header in this order: user-defined headers that specified in the advanced options, then for default headers: x-spamd-result, x-spam-score, x-spam-status, x-mailscanner-spamcheck. If a matched header is found the add-on doesn't try other headers even it can't find score in the header.

nyarlatothep commented

Ok, next try.
I installed the add-on "HeaderToolsLite" to try to edit my messages. As soon as i edit the message (for example adding a letter and removing it afterwards) right after closing the editor the column shows the correct spamscore!
So it seems to be a problem on my side. I don't know what changes when using HeaderToolsLite, if it's something with the encodingof the message, or the database within thunderbird. Will try to figure out.

You did a great job. Thanks a lot!
Greetings,
nyar

moisseev commented

Could you please save a message as .eml files before and after editing and compare the files?

nyarlatothep commented

Could you please save a message as .eml files before and after editing and compare the files?

I did this, both files have the same size, the same content and a compare with "fc" on windows shows only one difference as far as i can see: The Email Date differs.
Original Mail:
Date: Thu, 3 Jan 2019 18:40:39 +0300
Edited Mail:
Date: Thu, 3 Jan 2019 18:40:40 +0300
The edited mail is one second younger than the original. I think the addon does this, to force thunderbid to redraw/reload the message. And this maybe at the end shows the spamscore also.

I moved the mail with "X-ORG-MailScanner-SpamCheck" to the old account where the "X-Spam-Score"-Mails are correctly shown, but it doesn't show up there neither. Till now, only after this editing-thingy.

I'm lost, but will try further.
thanks.
Nyar.

EDIT: I fiddeld around with the settings "mailnews.customDBHeaders" and "mailnews.customHeaders" and now the column in my old server is also not showing. I need a break. ;)

moisseev commented

Could you please save a message as .eml files before and after editing and compare the files?

I did this, both files have the same size, the same content and a compare with "fc" on windows shows only one difference as far as i can see: The Email Date differs.
Original Mail:
Date: Thu, 3 Jan 2019 18:40:39 +0300
Edited Mail:
Date: Thu, 3 Jan 2019 18:40:40 +0300

I don't know how fc works. Probably it ignores something (like spaces, tabs, line endings, etc.). Can you share the samples?

Also it would be interesting to save both unedited and edited messages as .eml files, then drag-and-drop them to a Thunderbird folder and see what happens.

EDIT: I fiddeld around with the settings "mailnews.customDBHeaders" and "mailnews.customHeaders" and now the column in my old server is also not showing. I need a break. ;)

What do you have in extensions.rspamd-spamness.header, mailnews.customHeaders and mailnews.customDBHeaders ?

nyarlatothep commented

You don't give up, i appreciate this. Thanks a lot.

STOP: Forgive me! I didn't use the .zip download from github, but probably the old addon via the thunderbird download. I'm such an idiot. Doing too many things..
Sorry, sorry, sorry.
Will look into it again from the start...

nyarlatothep commented

Got everything working, exactly as you described.
Great work, makes my day much easier. Thank you very much.
Nyar

Just a small thing: There is no symbol in the message column, it shows just the text "Spam score (Rspamd)".

moisseev commented

Just a small thing: There is no symbol in the message column, it shows just the text "Spam score (Rspamd)".

It was removed on purpose since it conflicts with the sorting order icon (up/down arrow): b6d9635