Use native promises
niftylettuce opened this issue · 3 comments
niftylettuce commented
Use native promises
aheckmann commented
I would be in favor of native promises only when we drop support for all
versions of Node < 8.0.0. Some apps use domains, and before Node 8, native
Promises didn't support them which leads to hard to debug problems.
Bluebird works better.
…On Thu, Dec 28, 2017, 9:38 AM niftylettuce ***@***.***> wrote:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#93>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKLsrSSG_U_aR6BZKeidWMCymtAWyVRks5tE9H4gaJpZM4ROg5b>
.
vkarpov15 commented
We can close this for now, Automattic/mongoose#5945 makes it so that mongoose configures mquery to use native promises by default, so this isn't a necessary change as far as mongoose is concerned.
FWIW I haven't seen any apps that use domains, in my experience domains are badly broken. Have you seen people using domains @aheckmann ?
aheckmann commented
Kraken and restify (PayPal and Netflix)
…On Sun, Dec 31, 2017, 8:17 AM Valeri Karpov ***@***.***> wrote:
We can close this for now, Automattic/mongoose#5945
<Automattic/mongoose#5945> makes it so that
mongoose configures mquery to use native promises by default, so this isn't
a necessary change as far as mongoose is concerned.
FWIW I haven't seen any apps that use domains, in my experience domains
are badly broken. Have you seen people using domains @aheckmann
<https://github.com/aheckmann> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKLsqw4JYZMRjiFJm194vwmlyaSDmjxks5tF7OygaJpZM4ROg5b>
.