mosra/magnum

hasOcclusionRoughnessMetallicTexture() ignores combined metallic-roughness texture

pezcode opened this issue · 4 comments

pezcode commented

If a PBR material has a MaterialAttribute::NoneRoughnessMetallicTexture and a MaterialAttribute::OcclusionTexture, hasOcclusionRoughnessMetallicTexture() returns false.

It only checks for separate MetalnessTexture and RoughnessTexture, but not for combined NoneRoughnessMetallicTexture. This seems like an oversight to me, or is it intentional?

mosra commented

That seems like an oversight, yup. I'll look into this, just need to refresh my memory on what all needs to be checked to ensure it doesn't return false positives.

Thanks!

  • ❤️1
mosra commented

Fixed in 8203827. If you can confirm it works as expected with real-world glTF files, that'd be the most great :)

pezcode commented

Thank you! I'll test and report back

pezcode commented

Works great 😊 Tested with https://sketchfab.com/3d-models/zis-101a-sport-1938-a361c0f7b7e041fc8f3437a5cbec681a which previously failed to import the combined texture correctly

  • 🎉1