Js_boolean can't be found.

Question

Js_boolean can't be found.

Closed this issue 5 years ago · 7 comments

swuecho commented 5 years ago

742 │ Js_dict.set json "value" (Js_json.boolean (Js_boolean.to_js_boolean
v.Admin_types.value));
743 │ json

The module or file Js_boolean can't be found.

Answer 1 · 2019-10-26T09:06:56.000Z

We made some improvement so that js Boolean is the same as ocaml boolean 发自我的iPhone

…

------------------ Original ------------------ From: Hao Wu <notifications@github.com> Date: Sat,Oct 26,2019 4:29 PM To: mransan/ocaml-protoc <ocaml-protoc@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [mransan/ocaml-protoc] Js_boolean can't be found. (#138) 742 │ Js_dict.set json "value" (Js_json.boolean (Js_boolean.to_js_boolean v.Admin_types.value)); 743 │ json The module or file Js_boolean can't be found. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 2 · 2019-10-26T09:54:25.000Z

@bobzhang Indeed. Works fine after remove the translation . Thanks.

Answer 3 · 2019-10-28T20:28:55.000Z

I'll start working on this project again shortly. Getting back into bucklescript for a small project :)

Answer 4 · 2019-10-30T10:41:48.000Z

@mransan Welcome back. Waiting for anthor release.

Answer 5 · 2019-10-31T10:34:59.000Z

So I tried updating to opam 2.x.x but running into some issue with the simple build system that is currently used in ocaml-protoc

ocaml/opam-repository#15156

I'll start looking at Dune since it seems to be the most common build system.

Answer 6 · 2019-11-01T13:14:10.000Z

@swuecho new compiler is published: ocaml/opam-repository#15160

Answer 7 · 2019-11-02T11:37:23.000Z

upgraded and works great! thanks!