mrc-ide/deterministic-malaria-model

Package broken with recent testtthat/partially renamed

Closed this issue · 1 comments

See below for output. I am updating odin in a way that will break this model, but I need a working version in order to make the changes to your package for you.

For attention of @cwhittaker1000, @ettieunwin, and @OJWatson I presume?

> devtools::test()
Loading ICDMM
Testing ICDMM
✔ |  OK F W S | Context
✖ |   0 1     | test-compare_with_BM.R                                                                                                                                 
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error (test_compare_bm.R:2:1): (code run outside of `test_that()`)
Error: there is no package called 'hanojoel'
Backtrace:
 1. base::library(hanojoel) test_compare_bm.R:2:0
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✖ |   5 3     | test-demos_run.R [2.2 s]                                                                                                                               
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error (test_demos.R:34:3): create_r_model demo runs
Error: there is no package called 'hanojoel'
Backtrace:
 1. hanojoel:::create_r_model test_demos.R:34:2
 3. base::asNamespace(pkg)
 4. base::getNamespace(ns)
 5. base::loadNamespace(name)
 6. base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 7. base:::withOneRestart(expr, restarts[[1L]])
 8. base:::doWithOneRestart(return(expr), restart)

Error (test_demos.R:59:3): compare model outputs
Error: there is no package called 'hanojoel'
Backtrace:
 1. hanojoel:::create_r_model test_demos.R:59:2
 3. base::asNamespace(pkg)
 4. base::getNamespace(ns)
 5. base::loadNamespace(name)
 6. base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 7. base:::withOneRestart(expr, restarts[[1L]])
 8. base:::doWithOneRestart(return(expr), restart)

Error (test_demos.R:87:3): compare varying itns and not
Error: there is no package called 'hanojoel'
Backtrace:
 1. hanojoel:::create_r_model test_demos.R:87:2
 3. base::asNamespace(pkg)
 4. base::getNamespace(ns)
 5. base::loadNamespace(name)
 6. base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
 7. base:::withOneRestart(expr, restarts[[1L]])
 8. base:::doWithOneRestart(return(expr), restart)
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✖ |   0 1     | test-equilibrium_solution.R                                                                                                                            
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error (test_equilibrium_solution.R:2:1): (code run outside of `test_that()`)
Error: there is no package called 'hanojoel'
Backtrace:
 1. base::library(hanojoel) test_equilibrium_solution.R:2:0
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

══ Results ════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 2.3 s

[ FAIL 5 | WARN 0 | SKIP 0 | PASS 5 ]

No one is perfect!

Hi Rich - I think this has been fixed in PR #43. Will merge in January!