mudassir0909/jsonresume-theme-elegant

basics.image being ignored / profile photo missing

Opened this issue · 3 comments

garymm commented

I expect to see my profile photo taken from basics.image, but it is not:

Source:

{
    "basics": {
         "image": "https://media-exp1.licdn.com/dms/image/C5603AQHYBCIryEnWDQ/profile-displayphoto-shrink_800_800/0/1589651499542?e=1648080000&v=beta&t=0dpk7IJnhCTmWQSkYbjp_RRnZmIUZ0UjYl2eKR7uOtQ",
...

HTML output:

<img class="media-object img-circle center-block" data-src="holder.js/100x100" alt="Gary Miguel" src="https://s.gravatar.com/avatar/bc18c349133a64fe2c82a051a34adf5d?s=100&amp;r=pg&amp;d=mm" itemprop="image">

Currently rendered at:
https://registry.jsonresume.org/garymm?theme=elegant

From gist:
https://gist.github.com/garymm/35c108e4d0d8ee0be17c1a940584f6a9

Thanks for any help!

DerEinePete commented

Hi,
I do not know why, but you need to set the property basics.picture.

  • 👍3
gapuchi commented

There is a discrepancy between the theme and JSON Resume Schema. The schema uses image while this theme uses picture - https://github.com/jsonresume/theme-utils/blob/3ecd6dfe10f7a2abac366b40ec9065a4e89292e4/basics.js#L42

  • 👍3
JasonBenfer commented

Thank you. FWIW, I included both, which seems to work fine (covers both schemas regardless of theme type):

{
"basics": {
"name": "John Doe",
"label": "Programmer",
"image": "https://www.foo.com/myimage.jpeg",
"picture": "https://www.foo.com/myimage.jpeg",