mulinlab/CAUSALdb-finemapping-pip

Block variable never used

Closed this issue · 2 comments

reemagit commented

CAUSALdb-finemapping-pip/ref/01_prepare_reference.py

Line 44 in c817b26

chr_id, start, stop = blocks.loc[i].values[:-1]

The variable "block" doesn't seem to be used, but I am not sure if I got the code right, shouldn't line 44 be like below?

chr_id, start, stop = block.loc[i].values[:-1]

Notice that I replaced "blocks" with "block".

Same for line 83 (

CAUSALdb-finemapping-pip/ref/01_prepare_reference.py

Line 83 in c817b26

chr_id, start, stop = blocks.loc[i].values[:-1]
)

Jianhua-Wang commented

Thank you for pointing this out! I guess that I pasted the wrong code when converting jupyter notebook to py script. I've updated the code and now it should work correctly.

reemagit commented