mwrock/Chocolatey-Packages

Allow extra cmdline arguments for VisualStudio2013Ultimate

CumpsD opened this issue · 7 comments

Issue with the following package: https://github.com/mwrock/Chocolatey-Packages/blob/master/VisualStudio2013Ultimate/Tools/ChocolateyInstall.ps1

Here you are grabbing the install arguments for chocolatey, and using them to look through the AdminDeployment.xml to turn features on.

Afterwards you call the exe with the following args: /Passive /NoRestart /AdminFile $adminFile /Log $env:temp\vs.log

However, because of this, I am unable to pass extra args to the installer.

Would it be possible for you to change this, so you keep any unrecognized feature in the install arguments, and pass them on to the installer?

Then we can do the following: cinst VisualStudio2013Ultimate -InstallArguments "WebTools /ProductKey xxxxxxx"

We are using this to setup new dev machines, and now have to manually enter keys afterwards.

@CumpsD let me know if you'd like a build of https://github.com/kensykora/Chocolatey-Packages where I include this capability, or feel free to pull it down and run cpack yourself, until this can get merged in and published to chocolatey.

Awesome! I have pulled this in. Just running the packages through my test VMs and then I'll push. Thanks so much for this PR!

No problem, let me know if you need any support on this.

I should have mentioned that they were pushed. So we are all set. Thanks a bunch for the pr!

From: Ken Sykora [mailto:notifications@github.com]
Sent: Tuesday, April 8, 2014 8:27 AM
To: mwrock/Chocolatey-Packages
Cc: Matt Wrock
Subject: Re: [Chocolatey-Packages] Allow extra cmdline arguments for VisualStudio2013Ultimate (#15)

No problem, let me know if you need any support on this.


Reply to this email directly or view it on GitHub #15 (comment) .

Not seeing them in the repository here, and this issue is still open, but I do see it in Chocolatey -- didn't push it to github yet?

ugh. Exactly. Never pushed. oopsy daisy. Thanks for the nudge.

Thanks guys!