Presence in dockerhub?
Closed this issue · 8 comments
Ty for creating this image!
Couldn't it be available on dockerhub?
I expected to run it like:
docker-compose run --rm -v $PWD:/app --workdir /app/ui-tests nightwatch
(ui-tests folder has nightwatch.json,tests folder,commands folder, etc..)
Hullo!
Sure, we can publish the image to dockerhub.
Are you wanting to use the image outside of the structure defined in this project? I ask because you'll need to tweak the nightwatch.json config if that's the case. Just want to be clear about expectations. :)
As i see the project uses an image of the app to test it, but if i set a workdir like in the command that i posted, won't it work too without needing?
I'm not sure I understand what you're saying. Can you explain to me what you want to accomplish?
soz for my bad comm skils :(
Having the following project structure:
- core/
- public/
- doc/
- vendor/
- ui-tests/
I expect to simply run a command and get the nightwatch tests at ui-tests folder executed.
No worries! I just want to make sure I understand what you need so that I can help. 😃
Yes, we can publish a nightwatch docker image to dockerhub that will let you mount a directory such as ui-tests. Feel free to submit a PR that references this issue, or I'll try to get to it in the next couple of weeks.
EDIT: and to be clear, it'd be a docker image for running nightwatch. It wouldn't run a browser, a selenium hub, or the app under test. So the setup would be just like the one we're using in this project's docker-compose.yml config, only you wouldn't have to build the nightwatch docker image and you would need to mount your ui-tests directory onto the nightwatch docker container. Does that make sense?
Whenever we publish the image we'll update the README to explain this ^.
@psociety I meant to ask you this and I forgot --- Does our published nightwatch image meet your needs? Anything we can do to improve it?
So far i didn't have any problem. Now i can run my tests con CLI easily :)
Excellent!