Relationship mapping should return an error if relationship name is a field name
CraigLRussell opened this issue · 3 comments
If a relationship name is also a field name, both cannot be mapped in the same Projection.
To avoid confusion, we should disallow creating a relationship that has the same name as an existing field.
Fixed. TableMapping now checks for duplicates when adding fields and relationships.
Added new test cases to FieldMappingErrorTest.js.
Related question:
Should it ever be legal to call mapField() twice on the same field?
It currently is, but I am working on TableMapping right now and I could make it illegal.
On Sep 30, 2015, at 11:28 AM, Craig L Russell notifications@github.com wrote:
Closed #27.
—
Reply to this email directly or view it on GitHub.
There is a test in FieldMappingErrorTest t9 that tests that you cannot call mapField twice on the same field.
On Sep 30, 2015, at 11:39 AM, John David Duncan notifications@github.com wrote:
Related question:
Should it ever be legal to call mapField() twice on the same field?
It currently is, but I am working on TableMapping right now and I could make it illegal.
On Sep 30, 2015, at 11:28 AM, Craig L Russell notifications@github.com wrote:
Closed #27.
—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub #27 (comment).
Craig L RussellArchitect, Oraclehttp://db.apache.org/jdo408 276-5638 mailto:Craig.Russell@oracle.comP.S. A good JDO? O, Gasp!