nat236919/covid19-api

Key Error: when a country has a space or uses an abbreviation

Closed this issue · 9 comments

nat236919 commented

Ex.) South Korea

This will show an error when using

https://corona-api.herokuapp.com/country/south korea

nat236919 commented

South Korea, United Arab Emirates, Sri Lanka, Hong Kong

nat236919 commented

UK, US

dawenx commented

i noticed you changed "Mainland China" to "China", you might wanted to think about this a little bit more as Taiwan, Hong Kong, Macau has its own country/region name. i think that's why JHU chooses to use "Mainland China". just my 2 cents.

cbunicef commented

It would be very useful for my application if you included ISO two and three-letter country codes. That might also address some of these non-standard naming questions.

nat236919 commented

@dawenx @cbunicef
Thank you for your comments. Sure, I'm planning to add keep countries' original names as well as ISO two.

Please feel free to suggest more since I'm still fairly new.

nat236919 commented

1fa2fc7
The draft of #3 search by a country key or ISO (alpha2)

  • 👍1
array05 commented

Надеюсь json данные по API больше не будете изменять, иначе мое приложение перестает работать

nat236919 commented

@array05 My apology. That should be the last structure I significantly changed.

  • 👍1
array05 commented

@ array05 Мои извинения. Это должна быть последняя структура, которую я значительно изменил

@array05 My apology. That should be the last structure I significantly changed.

thanks, good work 👍