fetchOSD and related functions should return series names in title case

Question

fetchOSD and related functions should return series names in title case

Closed this issue 3 years ago · 2 comments

tools::toTitleCase

Possibly change the API:
https://stackoverflow.com/questions/6176057/convert-all-records-in-postgres-to-titlecase-first-letter-uppercase

Answer 1 · 2021-07-23T23:35:03.000Z

get_OSD() and the SoilKnowledgeBase OSD JSON files also return series names in all caps. I added a TODO to switch series names to title case. (ncss-tech/SoilKnowledgeBase#25; see for example https://github.com/ncss-tech/SoilKnowledgeBase/blob/main/inst/extdata/OSD/E/ECKRANT.json)

However this change strikes me as something that could wind up causing problems with backward compatibility. I am pretty used to these returning series name in all caps. And the file names are in all caps.

Answer 2 · 2021-07-26T18:00:21.000Z

Yeah, I'm not sure about the original justification. There are so many example of using upper case that broad-scale conversion to title case isn't warranted. Closing.