Simplify `construct_stimulus` and document stimulus in `example-0.5-aln-external-stimulus`
jajcayn opened this issue · 4 comments
jajcayn commented
A couple of things:
- delete
construct_stimulus
function fromutils.stimulus
; it has three modes and all of them can be achieved withModelInput
class:ac
is the same asSinusoidalInput
dc
is the same asStepInput
rect
can be easily done with a combination ofExponentialInput
andStepInput
with concatenation.. I will createRectifiedInput
directly in the file
- create a shortcut for creating stimulus to core neurolib models... before it was something like
construct_stimulus("ac", duration=model.params.duration, dt=model.params.dt, stim_amp=1.0, stim_freq=1)
; I proposeSinusoidalInput(amplitude=1.0, period=1000.0).to_model(model)
, such that duration and dt of stimulation will be directly read frommodel.params
- revamp example-0.5-aln-external-stimulus:
- swap all calls to
construct_stimulus
with new functions - create a section about
ModelInput
, what is implemented, how it looks like, what are the options (to_model
,as_array
,as_cubic_splines
) - showcase
SummedInput
andConcatenatedInput
(need to wait for #162)
- swap all calls to
caglorithm commented
This is so nice. We should schedule a day on which we discuss the new stimulus class together.... When would be good for you?
jajcayn commented
today: anytime before 5pm; tomorrow: before interareal meeting; Wednesday: anytime
caglorithm commented
Wednesday noon @ 12?
jajcayn commented
works, adding to cal