neurostuff/NiMARE

Set `n_iters=10000` default only for `null_method="montecarlo"`

JulioAPeraza opened this issue · 0 comments

Summary

It is a little confusing to set n_iters=10000 as the default even when a null_method="approximate" is used.

Additional details

  • NiMARE version: main

What were you trying to do?

This is also related to the reports module #773 when I tried to show the parameters used to fit the estimator.

What did you expect to happen?

Shows n_iters=None when null_method="approximate" is used.

What actually happened?

Shows n_iters=10000 when null_method="approximate" is used.

Fixing the bug

self.n_iters = None if null_method == "approximate" else n_iters or 10000