Beta design feedback
jancborchardt opened this issue · 10 comments
Discussed with @karlitschek and @marcoambrosini. cc @AndyScherzinger for awareness. Sorted by priority of visual impact.
Since we are in the beta stage and already beyond feature freeze, we need to focus on easy fixes.
- Sidebar tabs too present and conflict with primary buttons, especially in Talk: Style will be changed from full primary background highlight to underline. → FIX at nextcloud-libraries/nextcloud-vue#4815
- Share button too present: Style change to tertiary non-bold button (background will be removed and color adjusted to color-primary-element). → FIX at #41453
- Groupfolder and other folder icons are off: There is a dark icon with white stroke on color-primary icon. Instead icon should simply be color-primary-element-text on the color-primary-element icon – same logic as the primary button. → FIX at #41455
- Favorites button in sidebar overlaps icon/preview too much: "Favorite" can move to actions menu, and indicator to start of subline with size and modified date. #41481
- Comments layout improvements: Vertically align name with avatar, remove "" quotes so subline does not wrap. #41481
Additional second set of feedback:
- Black border in "New" menu in Safari: There is a black border on the first entry of the "New" menu. It should only appear on tab navigation, not on initial opening or interacting with the mouse. → Bug with Safari, does not appear with Chrome. @ShGKme can reproduce
Issue: nextcloud-libraries/nextcloud-vue#4874 - Some action menus have scrollbars: Issue exists at nextcloud-libraries/nextcloud-vue#3920 → According to @marcoambrosini @szaimen very complicated as the component would need logic to know where it is opened. Currently always 50vh to work in all circumstances.
- Time of calendar notification is based on first of a recurring meeting: The time in the notification should be based on the next meeting and not the first of a recurring event. → Christoph opened issue at #41615
- External storage settings layout looks off: Should be on top of the page, or properly integrated into emptycontent view → @marcoambrosini @szaimen #41614
- "Shared" label takes a lot of space in Files list for internal shares: → Proposals at #41620 #41656
Some more feedback from Jan:
Jan, the improvements already made are nice, especially that first one.
I do have an additional issue - not sure if it's design or a bug:
The copy/move can't be found there anymore. Those are far more typical operations on multi-select than the ones currently there. Should this be a separate issue?
@jospoortvliet good find – that is a separate issue as it's a functionality regression rather than a design issue. Also cc @AndyScherzinger for info.
Yes, I agree
separate issue as it's a functionality regression rather than a design issue, can you raise a ticket for it please? Thanks in advance
The copy/move can't be found there anymore. Those are far more typical operations on multi-select than the ones currently there. Should this be a separate issue?
@jospoortvliet where exactly is it missing? So @susnux can take care of fixing. #41450 (comment)
Well, next to the Delete button? The Delete used to not be there - on my 27.1 Nextcloud these options are there:
So we removed tagging - I don't care personally but I can imagine people who use tags do - and we removed copy/move. And we added delete.
Now when I select a bunch of files, I more often move them than that I delete them, so I would either replace delete with Copy/Move, or at least add copy/move.
oh and i have NO idea what 'select file range' is supposed to do, clicking it does nothing.
Issue for "Move or copy" opened at #41661, let’s keep the discussion over there since as said it’s not a design issue.
Maybe this is also something: #42098 -> the right click menu opening far from the cursor.
@AndyScherzinger @sorbaugh since there are only 2 issues remaining here, I would suggest scheduling those for the next Files cycle specifically and closing this issue so they don’t get lost.
Sounds good to me, can you take care of it @sorbaugh
Closing this then as we have follow-up issues. cc @sorbaugh for the scheduling – the menu scroll one I have noted for the next planning meeting from my side.