nextcloud/server

Dropbox API v1 will be shutdown: **June 28th 2017**

Closed this issue ยท 56 comments

We use that in the external storage app, if we want to keep the Dropbox provider (I honestly wouldn't mind removing it) then we need to update.

https://blogs.dropbox.com/developers/2016/06/api-v1-deprecated/

We should consider about that in the forums (where our users are).
...or we wait for what upstream does ๐Ÿ˜ˆ

Does the 'survey' app provide this info? @nickvergessen @schiessle ?
Because that could give us an indication how often this is actually used.

I dont think we get the type of mounts, just the numbers.
But anyway I'd say update

I dont think we get the type of mounts, just the numbers.

Add it? :P

As far as I can see we can't move while we support 5.4

So 11 sounds like a good point in time to do that ;)

Related IRC:

<PVince81> need to port the dropbox ext storage to the new API before June 2017: https://github.com/owncloud/core/issues/25969
<PVince81> any volunteers?
<DeepDiver> kill it

Muhaha ๐Ÿ˜ˆ

So kill in 12?

Please don't let it die. For me it is a very useful feature because I can avoid having to install the Dropbox client and still satisfy the need of using it because of my friends. Personally if it was just for me, Dropbox could go to hell.. ;)

I also see the use-case of @powerpaul17 ... Would cause many problems killing Dropbox API, because we have releases out there (9, 10, 11) which have a Dropbox Integration. Killing a feature which is already shipped seems to be problematic ... - So Dropbox API v2 would also be something we would need to backport to our stable-branches (or we use sell it as reason for upgrading ๐Ÿ˜ˆ)

  • is a seamless upgrade possible from user-perspective? (without re-adding the storage)

But ... Let me ask - how much time would it cost now and in the future to support this? ๐Ÿค” @nickvergessen

Nextcloud as a save and all-in-one home for your data - even if your friends are using the cloud service starting with D - this should be our goal (Of course only if it is worth) ๐Ÿ˜‰

No!!!! If we upgrade to v2 no way we will backport this. Changing libs is always risky but backporting is asking for troubles.

Date of death is June 28th 2017. We just need to make sure to have 12 out before that. Otherwise I don't see a way not to backport this.

@nickvergessen @LukasReschke @icewind1991 I guess we are late on this item here. I would vote to make this an app to get this nasty dependency out of the server part.

@nickvergessen @LukasReschke @icewind1991 I guess we are late on this item here. I would vote to make this an app to get this nasty dependency out of the server part.

Volunteers?

It would be nice to rip it out for 12. Just so that somebody that cares can fix it once v1 is EOL etc.

I took a quick look and basically

  • #4531 : else you need to make sure the app is after files_external (we load alphabetically)
  • You also need to rip out the oauth1 thingy
  • Probabaly a migration from current dropbox stuff to the new app

All in all more than I can do with my very limted files_external knowledge. And since I also don't use dropbox I might not be the best test person.

Final deprecation (i. e. turning off endpoints) seems to be postponed until end of September, so removal in 12.0.1 is not necessary:

https://blogs.dropbox.com/developers/2016/06/api-v1-deprecated/
https://blogs.dropbox.com/developers/2017/06/updated-api-v1-deprecation-timeline/

Well, maybe the GSOC results can be applied then to make it work with the new API. This could make for a smooth transition without killing access prematurely.

afaik Dropbox is no longer allowing users to create Oauth 1 end points as the current Dropbox API v2 only allows creation of Oauth v2. So anyone just starting out (like me) is totally unable to connect their Dropbox account to Nextcloud by following the Nextcloud 12 Adminstrative Documentation.

dropbox has definitly cancelled Oauth1 - was getting no connection since some days and didnt care (since i didnt know about their new policy) only to find out today that it's impossible to connect with Oauth1 today.
for me it isn't meag-important but as i have moved some files to there it would be nice to have (i know i could get them back by DL from dropbox and UL them to NC again

haxti commented

Dropbox Sync is still working here. Maybe only new connections will be rejected atm.

This seems to be the repository where the GSOC code for Owncloud will go:

https://github.com/owncloud/files_external_dropbox

Seems to depend on flysystem:

https://github.com/thephpleague/flysystem

Okay, since yesterday Dropbox support using v1 API is officially dead now.

Any updated plans for this issue?

go2sh commented

The owncloud app should also work with nextcloud. You can give it a try.

Hello , Where to find that app of owncloud and what is it called ?
As of 28th of Sept 2017 the app v1 is shutdown, only V2 works and we do not have access to that. Please react.

https://marketplace.owncloud.com/apps/files_external_dropbox
Install instructions are here: https://owncloud.org/blog/external-storage-dropbox/

Maybe you can get it to work for NC. However please check out the license, its GPLv2 and therefor can't be redistributed by Nextcloud or through the Nextcloud app store.

Have it running in my ownCloud instance as I can't make up my mind yet on the two options. Seems ownCloud has more dedication to quality but less of the newest feature which is hot and very early Alpha ...

Teyro commented

cant get it to work in nc.... says versions make nextcloud unstable....

Fixed the version part, than ran into the next error: It's making my nextcloud instance unstable... so can't activate...

Teyro commented

Same here... Makes me very sad :(

This is indeed bad. Somebody would have to make it compatible with Nextcloud and then there would have to be an exception in the App Store because of the GPLv2 license which sounds like a complicated mess.

go2sh commented

The restriction to AGPL seams odd to me. Its allowed to mix GPL and AGPL code and the GPL is compatible with the AGPL.

Teyro commented

Will Pay 25โ‚ฌ for adding Support

I've done a quick port of the app: https://github.com/icewind1991/files_external_dropbox

Since I don't use dropbox myself I would appreciate some testing before I push it to the appstore.
(I don't expect major issues, but as always when using unreleased software, make sure you have backups)

Teyro commented

Cant find the app at the app store :(

I'd be happy to if I could figure our how. I'm not seeing any documentation and it doesn't seem to be a drop-in replacement for what I see inside of apps/files_external

@icewind1991, getting "Error: This app can not be enabled because it makes the server unstable"

Edit: Sorry my fault. Need to build, not just clone.

If you are experiencing issues with the files_external_dropbox app, please open them in the related repo ;) THX!

Closing this, because it has been "resolved" with a new app:
https://github.com/icewind1991/files_external_dropbox

@nickvergessen Well, not completely:

  1. The now obsolete code for v1 would have to be removed.
  2. The new app would have to be put into the App Store (which is difficult because it would need an exception because of the GPLv2 license).
  1. The dropbox code seem to be already removed from our code base (didn't find it in php files anymore)
  2. Uploading it to the appstore is up to the owner of the app. So not sure why there should be an issue open in the server repo. Also when there is a license issue, the thing to do is: resolve the license issue or deal with it in a okay-way and not to add an exception to the appstore. Licenses and their incompatibilities have their reasons.

I'm puzzled that you say it's not in the code base. It's still documented: https://docs.nextcloud.com/server/12/user_manual/external_storage/external_storage.html

My 12.0.3 system still shows files all over. And I don't see any new app in the app store. So the feature is still listed on the web site, is broken, and the replacement doesn't work...

On my system, I still see:

find . | grep -i dropbox
./apps/files_external/js/dropbox.js
./apps/files_external/3rdparty/Dropbox
./apps/files_external/3rdparty/Dropbox/Exception.php
./apps/files_external/3rdparty/Dropbox/Exception
./apps/files_external/3rdparty/Dropbox/Exception/Forbidden.php
./apps/files_external/3rdparty/Dropbox/Exception/RequestToken.php
./apps/files_external/3rdparty/Dropbox/Exception/NotFound.php
./apps/files_external/3rdparty/Dropbox/Exception/OverQuota.php
./apps/files_external/3rdparty/Dropbox/API.php
./apps/files_external/3rdparty/Dropbox/OAuth.php
./apps/files_external/3rdparty/Dropbox/OAuth
./apps/files_external/3rdparty/Dropbox/OAuth/Zend.php
./apps/files_external/3rdparty/Dropbox/OAuth/Consumer
./apps/files_external/3rdparty/Dropbox/OAuth/Consumer/Dropbox.php
./apps/files_external/3rdparty/Dropbox/OAuth/Wordpress.php
./apps/files_external/3rdparty/Dropbox/OAuth/Curl.php
./apps/files_external/3rdparty/Dropbox/OAuth/ca-bundle.pem
./apps/files_external/3rdparty/Dropbox/OAuth/PHP.php
./apps/files_external/3rdparty/Dropbox/OAuth/PEAR.php
./apps/files_external/3rdparty/Dropbox/autoload.php
./apps/files_external/lib/Lib/Backend/Dropbox.php
./apps/files_external/lib/Lib/Storage/Dropbox.php
./core/doc/admin/_sources/configuration_files/external_storage/dropbox.txt
./core/doc/admin/_images/dropbox-2.png
./core/doc/admin/_images/dropbox-oc.png
./core/doc/admin/_images/dropbox.png
./core/doc/admin/_images/dropbox-6.png
./core/doc/admin/_images/dropbox-1.png
./core/doc/admin/_images/dropbox-5.png
./core/doc/admin/_images/dropbox-4.png
./core/doc/admin/_images/dropbox-3.png
./core/doc/admin/configuration_files/external_storage/dropbox.html

Yeah but it does not exist in master (going to be nextcloud 13), so it's already fixed for the next bigger release...

@sunjam, the license issue has been resolved. @icewind1991 forked the owncloud app at a commit where that code was AGPL licensed.

any progress on this? could someone share info on this app? is it final and working ? thank you

@tedd77, follow along here: https://github.com/icewind1991/files_external_dropbox
I haven't had any luck so far, as I keep getting redirected to a Google Oauth page, instead of Dropbox.

@ConorIA thank you. So if I understand well no luck so far to solve this !! although I consider important and high priority.

Please report any further bugs and problems in https://github.com/icewind1991/files_external_dropbox

Guys this really sucks. It was a great feature of Owncloud and then of course Nextcloud. Any chance we can get this released back into the core functionality of Nextcloud in a future release.

The files_external_dropbox that you are linking to is un-installable. README.md says to install it from the Nextcloud app store, but it doesn't exist there and there is no response to questions about it. Does anybody know what the migration path from Nextcloud to Owncloud looks like? I switched to Nextcloud early on, but I rely on this feature and it's time to get it working.

@jgoerzen The readme was updated. The described method (building it on your own) works for now. You have to enable the files_external app as well which isn't mentioned at the moment.