nf-core/rnaseq

NFCORE_RNASEQ takes values from global scope

Opened this issue · 0 comments

The workflow NFCORE_RNASEQ doesn't use any parameter and instead takes params values from the global scope instead of using them as inputs:

rnaseq/main.nf

Line 160 in 1af00b9

NFCORE_RNASEQ ()

Instead, it should be tightly scoped and only use things provided in the input block. A simple solution to this might be to use the params object as input:

    //
    // WORKFLOW: Run main workflow
    //
    NFCORE_RNASEQ( params )

This would improve scoping of the workflow and enable easier testing and code portability.