niteshpatel/ministocks

fetching data seems stopped working

Closed this issue · 17 comments

muziofg commented

today fetching data seems stopped working, I'm unable to see fresh updated stocks prices (nor automatic, nor manual)
API hasn't stopped working, for example I can query with success the url

"https://query1.finance.yahoo.com/v7/finance/quote?fields=symbol,regularMarketPrice,regularMarketChange,regularMarketChangePercent,regularMarketVolume,shortName,longName&symbols=META";

I have also tried to install from play store to a clean device a new instance of this app and trying to fetch data for a single ticker without success

I have tried to reproduce the behavior with this simple java SE software, but unfortunately it works for me


import java.net.URL;
import java.net.URLConnection;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;

class StockData{  
    public static void main(String args[]) throws Exception{
        String url = "https://query1.finance.yahoo.com/v7/finance/quote?fields=symbol,regularMarketPrice,regularMarketChange,regularMarketChangePercent,regularMarketVolume,shortName,longName&symbols=META";
        URLConnection connection = new URL(url).openConnection();
        connection.setConnectTimeout(30000);
        connection.setReadTimeout(60000);
        BufferedReader r = new BufferedReader(new InputStreamReader(connection.getInputStream()));  
        String line;
            while ((line = r.readLine()) != null) {
            System.out.println(line);  
        }
    }  
}

I don't know if, for example, on android platform URLConnection has a different (and banned) user agent

enricodevtest commented

I just wanted to confirm that you are not the only person experiencing this problem. The price updates are not happening right now for me too.

mossi1960 commented

Since 2 days the price updates are not happening for me too.

fabiorauber commented

Mine stopped working as well.

niteshpatel commented

@muziofg looks to be the user agent as you guessed. have pushed an update but Google has put it under view, not sure how long it takes. hopefully that fixes it. thanks for putting effort in to help diagnose

niteshpatel commented
  • ❤️1
niteshpatel commented
niteshpatel commented
bencew commented

Thanks for the update, Nitesh!
Are you going to initiate to update the F-droid version, too? I've the app installed from there

niteshpatel commented
bencew commented

Weird, the F-Droid page is linked here in the readme

niteshpatel commented
muziofg commented

This should be fixed now. Note that fixing this stuff requires a lot of effort as often not only the logic needs to be fixed, but updated versions of the programs I used for development need to be setup (since this app is not updated frequently) and configured.

I have seen it (and recognize the effort) by the last commit, now app requires at least Android 6.0 (plus some minimal changes, like enumerated property values), you can update the description on github/stores page to avoid misunderstandings.

In the commit I also have seen that now the app idenfing itself as "Ministocks - Stocks Widget". That's a honest choice, but exposes Ministocks to identification/ban risks, I was thinking more like an identification as Chrome/Firefox

Many thanks to you for the fast bugfixing

niteshpatel commented

Ah good points, will make a note. thank you

morganchristiansson commented

Maybe automating releases to Play Store / F-Droid using Github Actions ís a good idea?

niteshpatel commented

Maybe automating releases to Play Store / F-Droid using Github Actions ís a good idea?

The app is updated too infrequently for the effort to maintain this to be worthwhile. Also releasing to play store often includes additional steps some of which are based on Google policy changes etc. that frequently require manual unpredictable steps.

morganchristiansson commented

Having a pipeline that is not dependent on local tooling would make infrequent releases easier. Just a friendly suggestion.

niteshpatel commented

Appreciate the suggestion but totally disagree!