nko4/website

notify teams when judges click through

gerad opened this issue · 6 comments

https://github.com/nko4/website/blob/master/public/javascripts/2012.coffee#L37-L39

# notify team when judges click through
$('a[href^=http]').live 'mousedown', (e) ->
  $.post "/notify", { url: this.href }

hey @diasdavid could you take a look at the website and see if this is working, and, if not, see if you can get it working?

the idea is that teams can request to be notified via a twitter dm when a judge visits their app. this helps teams with multi-player apps ensure that there are some people around to interact with the judge when s/he's judging

https://github.com/nko4/website/blob/master/controllers/notifications.coffee#L17-L52

Hi @gerad , I was just testing it locally, the code logic seems to work pretty fine, but, there is one element missing, since the notification is made by DM, it means that not only the participants must have (mandatory) followed NKO account and, give us some way to know their twitter handles, that from what I see, we never considered that, it's only gh for participants

You should be able to add a twitter handle on your profile page. There
should be some instructions on the edit team page. Are they not clear?

On Wednesday, November 6, 2013, David Dias wrote:

Hi @gerad https://github.com/gerad , I was just testing it locally, the
code logic seems to work pretty fine, but, there is one element missing,
since the notification is made by DM, it means that not only the
participants must have (mandatory) followed NKO account and, give us some
way to know their twitter handles, that from what I see, we never
considered that, it's only gh for participants


Reply to this email directly or view it on GitHubhttps://github.com//issues/92#issuecomment-27933411
.

ah, it's there, but getting into the personal profile page, it's not so obvious, for example

screen shot 2013-11-07 at 02 38 33

I would strongly advise that you ask in the next email to everyone, to fill up their twitter handle in /people/me (I got there cause I knew the path) and that's important , if they want to be notified by the judges.

It's working again :)

https://github.com/nko4/website/blob/d6bb67104555bad779c4263cb9e9777b9c64f1cb/controllers/notifications.coffee

screen shot 2013-11-07 at 03 11 26

I just add to adapt to the new twitter API.

Have in mind I had to remove the URL we previously displayed, cause now twitter considers it as 'malware' and replies with an error if we put a URL on the DM

Awesome. Thanks for the fix @diasdavid