noatamir/pyladies-berlin-sprints

STYLE double-quote cython strings

Closed this issue · 5 comments

MarcoGorelli commented

task here is:

  1. add id: double-quote-cython-strings to

    https://github.com/pandas-dev/pandas/blob/3d0d197cec32ed5ce30d28b922f329510c03f153/.pre-commit-config.yaml#L29

  2. run pre-commit run double-quote-cython-strings --all-files

  3. git add -u, git commit -m 'double quote cython strings', git push origin HEAD`

Motivation for this comes from this comment

DeaMariaLeon commented

Should id: double-quote-cython-strings should replace id: cython-lint?
or should be in addition?

MarcoGorelli commented

in addition

DeaMariaLeon commented

I did the git push origin HEAD .. do I open the PR?

  • 🚀1
MarcoGorelli commented

yes please