node-casbin/mongoose-adapter

Install TypeScript as part of `devDependencies`

Closed this issue ยท 3 comments

Looking at the package.json, I noticed that the TypeScript npm package is installed as a direct dependency.

"dependencies": {
"@types/mongodb": "^3.6.11",
"mongodb": "^3.6.5",
"mongoose": "^5.12.3",
"typescript": "^4.2.3"
},

This means that every production installations of software depending on casbin-mongoose-adapter will have an often superfluous module, making node_modules/ a little bit bigger.

I suggest moving TypeScript dependency to devDependencies instead.

Before opening a PR, I wanted to ensure there is no hidden reason behind your initial decision.

@fdionisi Yes, you are right. PR is welcome.

๐ŸŽ‰ This issue has been resolved in version 3.0.1 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€