php-http/client-common 2.0 support

Question

php-http/client-common 2.0 support

Closed this issue 5 years ago · 8 comments

As the title says, support for php-http/client-common 2.0 would be nice to have in the long run.

Answer 1 · 2019-03-28T13:47:54.000Z

Do you know if it's possible to support both versions?

Answer 2 · 2019-03-28T13:52:17.000Z

Seems possible yes:
php-http/cache-plugin@561b544
Enables both versions on their cache plugin.
Seems like it's done through a BC Compatible trait found in the 2.x versions:
https://github.com/php-http/client-common/blob/master/src/Plugin/VersionBridgePlugin.php

Answer 3 · 2019-03-28T14:03:16.000Z

But I don't think you are even using something in your bundle that would actually require any change (from what I could see while quickly looking over it) so just allowing version 2.x as well should probably work already.

Answer 4 · 2019-03-28T14:48:21.000Z

Want to contribute maybe? 🙂

Answer 5 · 2019-04-04T10:31:49.000Z

Seems like some packages are dropping PHP 5.6 support with version 2.0 so if you want to keep that in it's probably not possible to update.

Answer 6 · 2019-04-04T10:56:40.000Z

I've started refactoring for v2 which uses PSR http client interface, so you could use any compatible client, but don't have time now to complete it

Answer 7 · 2019-07-19T04:28:46.000Z

Upgraded dependencies so client-common 2.0 should work.

Answer 8 · 2019-07-19T11:19:15.000Z

Thank you! пт, 19 июл. 2019 г., 9:28 Tomas Norkūnas <notifications@github.com>:

…

Upgraded dependencies so client-common 2.0 should work. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#117?email_source=notifications&email_token=ADNRXMPWSFC3KYGW2BAAIGTQAE7IBA5CNFSM4HCAXVBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KRDPA#issuecomment-513085884>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADNRXMKP7GMCT4U3C3WUWFLQAE7IBANCNFSM4HCAXVBA> .