numerai/tournament-contracts

Issues

• Here we assume the ratio is always infinite, could add a check on the balance before and after to validate

  #31 opened 5 years ago by thegostep
  0

• Consider changing modifier to onlyOwner()

  #30 opened 5 years ago by thegostep
  0

• Could store tokens in this contract to avoid additional cost of transferFrom. Would save approx 60k gas per call

  #29 opened 5 years ago by thegostep
  0

• newAllowance instead of newAmount?

  #27 opened 5 years ago by thegostep
  0

• reward and increase stake could share same code to avoid duplicate

  #28 opened 5 years ago by thegostep
  0

• best to describe these functions as owned rather than internal

  #26 opened 5 years ago by thegostep
  0

• can remove safemath for uint128

  #24 opened 5 years ago by thegostep
  0

• Wallet should have method to transfer ETH and tokens

  #36 opened 5 years ago by thegostep
  0

• Frontrunning bug with currentStake not fixed correctly

  #25 opened 5 years ago by thegostep
  1

• consider adding input validation that amount to release + change are non-zero

  #34 opened 5 years ago by thegostep
  0

• This deployment does not use the upgradability pattern

  #33 opened 5 years ago by thegostep
  0

• calling increaseStake() here prevents you from using this function for self-custody users

  #32 opened 5 years ago by thegostep
  0

• Style: can declare interface in place

  #14 opened 5 years ago by thegostep
  0

• TournamentV3 increaseStakeErasure

  #12 opened 5 years ago by kumikoda
  0

• Remove use of pre-determined contract address

  #8 opened 5 years ago by thegostep
  0

• Use interface to avoid large code import

  #9 opened 5 years ago by thegostep
  0