Communicator failures not handled
jjlawren opened this issue · 1 comments
jjlawren commented
Messages such as this lead to failures when updating zones:
May 12 10:08:59 [00000001000000000A--],0fc,[f704009f10fc000008020000000000],"COMM. FAILURE "
May 12 10:09:03 [00000001000000100A--],0bf,[f704009f10bf000208020000000000],"CHECK 103 LngRngRadio 0000"
Traceback (most recent call last):
File "/usr/local/lib/python3.8/threading.py", line 932, in _bootstrap_inner
self.run()
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/devices/base_device.py", line 148, in run
self._device.read_line(timeout=self.READ_TIMEOUT)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/devices/socket_device.py", line 356, in read_line
self.on_read(data=ret)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/event/event.py", line 84, in fire
func(self.obj, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/decoder.py", line 1041, in _on_read
self._handle_message(data)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/decoder.py", line 439, in _handle_message
msg = self._handle_keypad_message(data)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/decoder.py", line 481, in _handle_keypad_message
self._update_internal_states(msg)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/decoder.py", line 632, in _update_internal_states
self._update_zone_tracker(message)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/decoder.py", line 1017, in _update_zone_tracker
self._zonetracker.update(message)
File "/usr/local/lib/python3.8/site-packages/alarmdecoder/zonetracking.py", line 209, in update
self._zones_faulted.sort()
TypeError: '<' not supported between instances of 'str' and 'int'
f34rdotcom commented
This should be easy enough to fix. The hex value breaks it.