Revise image handling

Question

Revise image handling

Closed this issue a month ago · 7 comments

save resized images to original folder, then point to resized image

Answer 1 · 2022-08-11T17:38:38.000Z

This makes me wonder where we should really store images.

The banner images are all in story-specific folders, but it would be DRYer to keep them in static/images and use .params.image to have an absolute reference to the image url. We do re-use a lot of images - very few are specific to a data story (and we could keep those in the page bundle - the content folder).

Answer 2 · 2022-08-18T13:43:39.000Z

I changed this issue title to be more general. Let's address two things:

resize header / card images (CG)
Change data story images - keeping them in static/images and updating the reference to the banner image
Give images descriptive names (for seo)

Answer 3 · 2022-09-19T16:09:23.000Z

This might be a reach but is there any way that this merge may have affected the search? Entering a search term yields nothing but this console error - a baseURL issue

Answer 4 · 2022-09-19T16:23:16.000Z

Yeah, I'm on it.

…

________________________________ From: M. Montesano ***@***.***> Sent: Monday, September 19, 2022 12:09 PM To: nychealth/EH-dataportal ***@***.***> Cc: Chris Gettings ***@***.***>; Author ***@***.***> Subject: [EXTERNAL] Re: [nychealth/EH-dataportal] Revise image handling (Issue #43) CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Forward suspect email to ***@***.******@***.***> as an attachment (Click the More button, then forward as attachment). This might be a reach but is there any way that this merge may have affected the search? Entering a search term yields nothing but this console error - a baseURL issue [image]<https://user-images.githubusercontent.com/55593359/191062892-6039ce8e-fd33-42b0-afaa-e255387ed73c.png> — Reply to this email directly, view it on GitHub<#43 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADAZMQCBDF2OWHN3ODJPJTLV7CF33ANCNFSM56ITLGCQ>. You are receiving this because you authored the thread.Message ID: ***@***.***> Sent from the New York City Department of Health & Mental Hygiene. This email and any files transmitted with it may contain confidential information and are intended solely for the use of the individual or entity to whom they are addressed. This footnote also confirms that this email message has been swept for the presence of computer viruses.

Answer 5 · 2023-07-10T13:12:51.000Z

+, Add a conditional statement, with a default image, to image references (index.html template, data stories section and single templates, and anything else relevant) so that when new content is created, if it doesn't have an image and image reference, builds will still complete.

Hey @cgettings, I started establishing a default image that gets overridden if .Params.image is specified, for data stories. That way we won't have build errors prior to adding an image. But, I'm running into an issue involving .Resize code. I think this only works if it's called on a Resource, rather than a string, and I'm having a hard time either doing that to a site-level resource (the default image), or converting strings to resources. I've tried unsuccessful things that I won't commit - using conditionals, with, Scratch, and other approaches to manage the logic but keep on running into one issue or another. I don't want to ditch use of Resize altogether, since it's especially important on the home page, key-topics, and data-stories section pages (where we're loading thumbnails). Not sure how to get this working though.

Answer 6 · 2023-07-21T13:06:38.000Z

this is currently on hotfix-ds-default btw.

Answer 7 · 2024-08-06T14:42:48.000Z

Closed to consider dealing with later.