Error: failed to load base spec from <base> with error converting YAML to JSON: yaml: unmarshal errors

Question

Error: failed to load base spec from <base> with error converting YAML to JSON: yaml: unmarshal errors

Closed this issue a year ago · 11 comments

Despite locally it works perfectly with .deb from https://github.com/Tufin/oasdiff/releases/tag/v1.9.6 and same base and rev files, in GitHub Action I get:

Error: failed to load base spec from "openapi/oh.yaml" with error converting YAML to JSON: yaml: unmarshal errors:
  line 7991: mapping key "empty" already defined at line 7980
  line 8048: mapping key "empty" already defined at line 8037
  line 8107: mapping key "empty" already defined at line 8096
  line 8159: mapping key "empty" already defined at line 8148
  line 8216: mapping key "empty" already defined at line 8205
  line 8287: mapping key "empty" already defined at line 8276
  line 8344: mapping key "empty" already defined at line 8333

https://github.com/mwithi/openhospital-api/actions/runs/6936878852/job/18869869828#step:12:15

base: oh.yaml.txt (link)
rev: oh_rev.yaml.txt (link)

Note: I'm using my fork inspired by #19, but the error is the same with oasdiff/oasdiff-action/breaking@main

Answer 1 · 2023-11-21T18:41:21.000Z

Despite locally it works perfectly with .deb from https://github.com/Tufin/oasdiff/releases/tag/v1.9.6 and same base and rev files, in GitHub Action I get:
Error: failed to load base spec from "openapi/oh.yaml" with error converting YAML to JSON: yaml: unmarshal errors:
  line 7991: mapping key "empty" already defined at line 7980
  line 8048: mapping key "empty" already defined at line 8037
  line 8107: mapping key "empty" already defined at line 8096
  line 8159: mapping key "empty" already defined at line 8148
  line 8216: mapping key "empty" already defined at line 8205
  line 8287: mapping key "empty" already defined at line 8276
  line 8344: mapping key "empty" already defined at line 8333
https://github.com/mwithi/openhospital-api/actions/runs/6936878852/job/18869869828#step:12:15

base: oh.yaml.txt (link) rev: oh_rev.yaml.txt (link)

Note: I'm using my fork inspired by #19, but the error is the same with oasdiff/oasdiff-action/breaking@main

It is working for me, see:

running action: https://github.com/oasdiff/oasdiff-action/actions/runs/6948164192
PR including your specs: #22
below the output from github:

Answer 2 · 2023-11-21T19:01:12.000Z

Thank you @effoeffi, any hint? maybe my yamel is wrong? Do you see something not correct?
https://github.com/mwithi/openhospital-api/blob/test-OH2-246_base/.github/workflows/openapi.yml

Thanks

Answer 3 · 2023-11-21T19:06:38.000Z

Thank you @effoeffi, any hint? maybe my yamel is wrong? Do you see something not correct? https://github.com/mwithi/openhospital-api/blob/test-OH2-246_base/.github/workflows/openapi.yml

Thanks

I did not check your fork.
May I ask, why do you prefer to work with a fork?

Answer 4 · 2023-11-21T21:17:01.000Z

Hi @mwithi,
I noticed that the link to base above downloads oh.yaml.txt while your GitHub action output shows that you are comparing openapi/oh.yaml (not .txt).
Perhaps this is the problem?

Answer 5 · 2023-11-21T21:46:50.000Z

Hi @mwithi, I noticed that the link to base above downloads oh.yaml.txt while your GitHub action output shows that you are comparing openapi/oh.yaml (not .txt). Perhaps this is the problem?

@reuvenharrison no, I've renamed them .txt because otherwise GitHub won't accept the upload

Answer 6 · 2023-11-21T21:52:06.000Z

Thank you @effoeffi, any hint? maybe my yamel is wrong? Do you see something not correct? https://github.com/mwithi/openhospital-api/blob/test-OH2-246_base/.github/workflows/openapi.yml
Thanks

I did not check your fork. May I ask, why do you prefer to work with a fork?

@effoeffi because I'm simulating contributions from other devs

Answer 7 · 2023-11-21T22:36:29.000Z

@effoeffi Or do you refer to my oasdiff fork? As I put in the Note: I'm using my fork inspired by #19, but the error is the same with oasdiff/oasdiff-action/breaking@main. Reverted to oasdiff now, with same result.

Answer 8 · 2023-11-21T22:52:43.000Z

@effoeffi Are these services still working? https://www.oasdiff.com/diff-as-a-service

Answer 9 · 2023-11-22T00:10:11.000Z

@reuvenharrison should I open this issue in https://github.com/Tufin/oasdiff ?

Answer 10 · 2023-11-22T14:31:25.000Z

Sorry my mistake: it turned out that the problem was in the base file initially provided in the repo and not in the generated revision which was really ok indeed. Lesson learnt: to always revise assumptions! 😅

Thank you all for the support and congrats for this great tool! 👏

Answer 11 · 2023-11-22T20:09:42.000Z

@effoeffi Are these services still working? https://www.oasdiff.com/diff-as-a-service

@mwithi Yes it is working. Please, join our community in slack, we will continue the conversation in there
https://join.slack.com/t/oasdiff/shared_invite/zt-27l6y20xw-hcwzpcA7v8FobfRogTCgtg