oddbird/susy

_support.scss : Calling call() with a string has been deprecated in Sass 3.5 and will break in Sass 4.0

tim-durrant opened this issue · 11 comments

tim-durrant commented

I discovered this today when I upgraded to Sass 3.5, and received several deprecation warnings. There will be a code fix required as follows:

Line 70 in susy/sass/susy/output/support/_support.scss

$_pass: call(unquote("#{$_type}-exists"), $_i);

needs to be modified to

$_pass: call(get-function(unquote("#{$_type}-exists")), $_i);

More details: http://blog.sass-lang.com/posts/809572-sass-35-release-candidate

mirisuzanne commented

Yeah, In order to be compatible with both pre and post 3.5, we need to do a bit more workaround. I've fixed that in Susy 3, hopefully out soon, but I'd love a PR for something similar in Susy 2. Interested in submitting a patch?

tim-durrant commented

Sure. Actually a newbie to Github :-) Have you got any specific procedures to follow for a patch or is there generic doco online? Cheers!

mirisuzanne commented

Oh, fun learning time for you! I'm sure there are articles, but I don't know off-hand. I'm also happy to help how I can. How experienced are you with Git generally? The steps are (roughly):

  1. "Fork" this repository with the button up top.
  2. On your own fork of the project, use the "clone or download" button to get the address, and run git clone <address> <local-directory> (replacing those ) in a terminal window to get the local version.
  3. Run git branch -b <branch-name> to create a new branch
  4. make your changes in the sass dir!! (add tests if you can, in the test/sass dir)
  5. rake test to make sure all the tests are passing.
  6. git add .; git commit -m '<explain the commit>' to commit your changes
  7. git push -u origin <branch-name> to put it all back on github
  8. Hit the new pull request button on your github fork — select our repo/master-branch as the "base", and your repo/new-branch as the "head"
  9. Submit your pull request!

So I gave you a lot of detail on the git steps without much real detail on the git steps... Let me know if you have any questions, or get stuck. I'm happy to expand or clarify if I can.

Jameskmonger commented

@mirisuzanne Does this need to be done against the susytwo branch in order to fix it for v2?

mirisuzanne commented

@Jameskmonger that's right, though I'm not sure the solution above is the best (see http://oddbird.net/2017/03/30/safe-get/). If you want to do that, I'm happy to consider a pull request! Thanks!

mirisuzanne commented

Fixed by 8e5dab9

  • 🎉6
brograhamer commented

Hey, I'm sorry to reopen this request @mirisuzanne and @nigelheap. This issue still stands. Experienced the message today for the first time. I applied the patch but still receiving the error. Any thoughts?

mirisuzanne commented

@brograhamer Can you provide a stripped-down example (preferably in a GitHub repo) that demonstrates the error? I'm not able to reproduce it locally.

Jameskmonger commented

I'm also not able to reproduce @mirisuzanne

brograhamer commented

@mirisuzanne working on it, I'll either post back today with incompatibilities with other components, a patch, or a stripped down project for you to check. Sorry for the delay.

Edit: was able to use v 2.2.14 cleanly without an error, problem must be related to something else in my code. Seeing the OP comment about this made me think it was Susy related but I should have done my own testing first. If I find an actual problem with Susy I'll make a new ticket. Sorry!

mirisuzanne commented

No problem, that's what stripped-down examples are for - half the time they solve the problem. :) Thanks for the update!