svelte-router issues

[ohait]

I was fixing the hardcoded item_supplier code by allowing url like: /#/item/NO:12345/03010123456789
and i modified the router like '/item/:item_supplier/:item_id'

but i noticed it doesn't matter much what is written after the column, the value will be assigned to path.item instead of path.item_supplier or item_id

It might be a bug, but i couldn't understand how the router works, so i ended up using a column and splitting over it in page/Item.html which is suboptimal.

maybe the whole router should be reviewed by someone that knows better than me? . o ( @bensinober )

[ohait]

I actually found out why it was not working for me, the RegEx was not allowing the underscore, truncating :item_supplier and :item_id to :item and causing lots of confusion. working now

[bensinober]

I belive this should work. Need to make sure underscore is included in path regexp option though 26. mar. 2018 14:34 skrev "Francesco Rivetti" <notifications@github.com>:

…

I was fixing the hardcoded item_supplier code by allowing url like: /#/item/NO:12345/03010123456789 and i modified the router like '/item/:item_supplier/:item_id' but i noticed it doesn't matter much what is written after the column, the value will be assigned to path.item instead of path.item_supplier or item_id It might be a bug, but i couldn't understand how the router works, so i ended up using a column and splitting over it in page/Item.html which is suboptimal. maybe the whole router should be reviewed by someone that knows better than me? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWLSgI-0kbx0sNDJpYmTawIUuCJX6reks5tiOA4gaJpZM4S7ChH> .