okbob/plpgsql_check

Compilation warnings without --enable-cassert flag

surajkharage19 opened this issue · 3 comments

surajkharage19 commented

Hi,

I am getting below repeated warnings if I compile plpgsql_check extension against PG15 (compiled version without --enable-cassert flag).

edb@localhost:plpgsql_check$ make
gcc -std=gnu99 -Wextra -g -fPIC -I/home/edb/PG_master/PG15/lib/postgresql/pgxs/src/makefiles/../../src/pl/plpgsql/src -Wall -I. -I./ -I/home/edb/PG_master/PG15/include/postgresql/server -I/home/edb/PG_master/PG15/include/postgresql/internal  -D_GNU_SOURCE -I/usr/include/libxml2   -c -o src/plpgsql_check.o src/plpgsql_check.c -MMD -MP -MF .deps/plpgsql_check.Po
In file included from /home/edb/PG_master/PG15/include/postgresql/server/access/htup_details.h:21:0,
                 from /home/edb/PG_master/PG15/include/postgresql/server/access/relscan.h:17,
                 from /home/edb/PG_master/PG15/include/postgresql/server/access/tableam.h:20,
                 from /home/edb/PG_master/PG15/include/postgresql/server/commands/trigger.h:16,
                 from /home/edb/PG_master/PG15/include/postgresql/server/plpgsql.h:21,
                 from src/plpgsql_check.h:3,
                 from src/plpgsql_check.c:26:
/home/edb/PG_master/PG15/include/postgresql/server/storage/bufpage.h: In function ‘PageValidateSpecialPointer’:
/home/edb/PG_master/PG15/include/postgresql/server/storage/bufpage.h:313:33: warning: unused parameter ‘page’ [-Wunused-parameter]
 PageValidateSpecialPointer(Page page)

IIRC, we don't use --enable-cassert flag while generating the packages. Can we do something here?

okbob commented
surajkharage19 commented

Thanks for the quick fix, Pavel. Marking this as closed.

okbob commented

Thank you for report