[FEATURE] Add option to provide custom discovery url
Ced-Sharp opened this issue · 1 comments
Ced-Sharp commented
I had to use an API which is not part of googleapis.com which means the discovery part would always fail.
when using aiogoogle.discover('content', 'v1')
it would default to google's shopping content api, which is not what I was targeting.
Since the sole purpose of .discover()
is to download the discovery doc from a guessed url, I believe adding an optional parameter discoveryDocumentUrl
(like the original google api) would benefit those cases like mine where a custom discovery url is need.
Right now, what I had to do was bypass .discover()
and instantiate GoogleAPI
manually, which I don't believe to be the best approach considering the api.
omarryhan commented
Hey, sounds reasonable. I'll be happy to accept a PR. Thanks!
…On Thu, May 5, 2022 at 12:02 AM CedSharp ***@***.***> wrote:
I had to use an API which is not part of googleapis.com which means the
discovery part would always fail.
when using aiogoogle.discover('content', 'v1') it would default to
google's shopping content api, which is not what I was targeting.
Since the sole purpose of .discover() is to download the discovery doc
from a guessed url, I believe adding an optional parameter
discoveryDocumentUrl (like the original google api) would benefit those
cases like mine where a custom discovery url is need.
Right now, what I had to do was bypass .discover() and instantiate
GoogleAPI manually, which I don't believe to be the base approach
considering the api.
—
Reply to this email directly, view it on GitHub
<#94>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGPFI5OJTCNHRDRC3UHARPTVILXXNANCNFSM5VDKJCFQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>