NVMe: high level model - review findings
Opened this issue · 0 comments
boekholt commented
Comments gathered during review of nvme_top_i.sv:
- Handling of error conditions for NVMe read and write operations is missing.
- Is it possible to remove the
#1
operation at the end of tasksnvme_cmd_read
and `nvme_cmd_write? - Should we remove the unused task
ddr_axi_test
? - Is task
axi_ddr_reset
required? - Set
ACT_bresp
andACT_rresp
to2'hx
together with releasing ofACT_bvalid
andACT_rvalid
- Add support for NVMe host admin registers
- Add NVMe lite model description (copy README.md from ibm github)
- Action Register Write Statemachine: Probably need to delay issuing of
nvme_operation()
in stateWRITE_BUFFER
similar to theWRITE_BURST
implementation