Create global phase-fold function and use everywhere phase folding is done.

Question

Create global phase-fold function and use everywhere phase folding is done.

Opened this issue 11 years ago · 2 comments

As reported in the source code:

NOTE (SWF): There is a bug here because if the startings phase of the transit is close to 1.0 and the duration pushes it over, it will not wrap properly as written.

light_curve.flux[(transit_phase > phase) & (transit_phase < (phase + transit_ratio))] -= transit_depth

Answer 1 · 2014-07-02T19:15:16.000Z

Instead of fixing this bug, we want to make a generic "phase_fold" algorithm and use it throughout the project, since @emprice phase-folding is done differently anyways and invalidates this bug.

Answer 2 · 2014-08-19T14:54:10.000Z

Optional as time allows for now, otherwise remove the Milestone label.