opencb/jsorolla

Empty sections in Variant Browser Settings

Closed this issue · 2 comments

Describe the bug

In the Variant Browser settings modal, the Sample Genotype section is hidden but a pill with this section title is displayed.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Variant Browser.
  2. Click on Settings button.
  3. Click on Sample Genotype pill.

Expected behavior

Empty or hidden sections should be removed from tabs and pills.

Screenshots

image

Additional context

This issue is related with #371.

Fixed in commit 2232797: empty sections are hidden from tabs or pills on Variant Browser:

image

In the Sample Variant Browser the Sample Genotypes setting pill is displayed as expected:

image

pamag commented

Reviewed

OpenCGA commit: bcbe75e68198a1171ad977e747189ddcdbc74c39
IVA commit: 1dfdef8b5ea4365a40f871bed8752016628b710f

FIXED