opencb/jsorolla

CellBase url hardcoded at jsorolla

pamag opened this issue · 1 comments

pamag commented

Describe the bug

There is a CellBase url hardcoded at jsorolla. This is problematic with some clients that use IVA through VPN and have their own CellBase an almost all network connection blocked to outside sites. So this hardcoded url is a big problem.

https://github.com/opencb/jsorolla/blob/release-2.2.x/src/webcomponents/variant/interpretation/variant-interpreter-grid.js#L78

   // FIXME Temporary fix in IVA, THIS MUST BE FIXED IN CELLBASE ASAP!
        this.cellbaseClient = new CellBaseClient({
            host: "https://ws.zettagenomics.com/cellbase",
            version: "v5",
            species: "hsapiens"
        })

variant-interpreter-grid.js

        this.cellbaseClient = new CellBaseClient({

There is a call in this line
https://github.com/opencb/jsorolla/blob/release-2.2.x/src/webcomponents/variant/interpretation/variant-interpreter-grid.js#L310 con cellbaseClient.
variant-interpreter-grid.js

                                this.cellbaseClient.get("feature", "gene", geneNamesString, "info", {

@pamag I have removed the code in 2.2.1