opencobra/MASSef

eqRateConstsSub in G3PD2

dczielinski opened this issue · 3 comments

the variable eqRateConstsSub in G3PD2 is set to {} right after it's created. Is this intended/what's the reason this has to be done?

In general, it would be great if the King-Altman section could be the same between notebooks - G3PD2 and ADK1 and PGM all feel very different and it's hard to see how they're functioning. If we could just add some if statements and use the same giant block of code with case handling, that would be ideal to me. Thoughts?

e.g. getRateEqs has way more arguments in G3PD2 than in PGM. I'd prefer that they all had the same number of arguments, but the optional arguments are set to {} in PGM to make it transparent what's happening.

i'll try to create those blocks next week, both for the build module part and simulate data
be careful with the optional arguments values, they can crash the functions, use something like:
maxSimplifyTime = 300, nActiveSites=1, label=""

addressed in commit 7519a14
now getRateEqs is part of the function setUpFluxEquations[] which sets up all flux equations and export them to files.