Add new fields to information structures (psu, fan)

Question

mmaracine-dn opened this issue 3 years ago · 3 comments

Hi everyone,

I was wondering if we can extend some of the information structures with more fields.

For the PSUs struct, it would be fru product version (revision) data, capacity and maximum capacity;
For FAN struct, it would be max fan speed.

Thank you

Answer 1 · 2021-10-05T15:00:28.000Z

Have you reviewed the onlpv2 design? It is much more flexible than onlpv1.

On Tue, Oct 5, 2021, 7:25 AM mmaracine-dn ***@***.***> wrote: Hi everyone, I was wondering if we can extend some of the structures for sensors with more information. - For the PSUs struct, it would be fru product version (revision) data, capacity and maximum capacity; - For FAN struct, it would be max fan speed. Thank you — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#857>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAP5WH63UAWYWWMVY3YEA7DUFMDG7ANCNFSM5FL3VLBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Answer 2 · 2021-10-05T15:38:31.000Z

Hey,
I have the v2 branch as a reference for the code. In what sense it's more flexible?

Answer 3 · 2021-10-13T13:25:18.000Z

hey, just in case I wasn't very clear, I opened a PR with the changes I had in mind, it's PR 859