Set a different upstream manager module

Question

Set a different upstream manager module

Tieske opened this issue 9 years ago · 3 comments

The module currently relies on the ngx.upstream module for managing the upstreams.

Unfortunately we cannot use that module for our usecase. See discussion here

Would you accept a PR to set the module explicitly, making it configurable? so I won't have to fork the code.

If so, should it be a setting on module level (in an upvalue, shared by all checkers spawned), or a setting per spawned checker. Imho the latter, but please share your thoughts.

Answer 1 · 2016-01-15T21:45:42.000Z

@Tieske That makes sense. I prefer passing the concrete upstream object via an argument option too.

Answer 2 · 2016-01-15T22:10:39.000Z

Ok, Thx for the heads up. I'll work on a PR. Will you be merging #10? so I can base the new PR on that (otherwise it will surely deliver some conflicts)

Answer 3 · 2016-01-16T02:38:43.000Z

closing this in favor of #12