[META] Update all instances of admin:admin across different repositories

Question

[META] Update all instances of admin:admin across different repositories

Closed this issue 7 months ago · 45 comments

Description

There are many instances of admin:admin credentials usage across different repositories. They will be affected by the change to replace hard-coded admin password with a dynamic value. This issue requests fixing all those instances of admin credentials to address this breaking change.

Acceptance Criteria

All hard-coded instances across repos are addressed
Ensure that tests, if any, work as expected

Tasks

Search and update the references to admin:admin, password admin and demo install script in following repos, as required:
(to track work done, tag the PR next to the repo name)

(Legend: ❌ - no updates, 🕐 - in progress, ⏳ - Waiting 2.12 release, ✅ - complete)

Status	Repo	PR	Issue	Notes
⏳	logstash-output-opensearch	#233	#234	will be merged post 2.12 release
⏳	opensearch-benchmark	#430	#474	will be merged post 2.12 release
⏳	opensearch-go	#449	#459	will be merged post 2.12 release
⏳	opensearch-js	#669, #707	#699	will be merged post 2.12 release
⏳	opensearch-migrations	#480	#479	will be merged post 2.12 release
⏳	opensearch-py	#631	#648	will be merged post 2.12 release
⏳	opensearch-rs	#234	#236	will be merged post 2.12 release
⏳	opensearch-ruby	#217	#222	will be merged post 2.12 release
⏳	reporting-cli	#56	#58	will be merged post 2.12 release
⏳	terraform-provider-opensearch	#138	#146	will be merged post 2.12 release

Status	Repo	PR	Issue	Notes
✅	alerting	#1399	#1347
✅	alerting-dashboards-plugin	#849	#861
✅	anomaly-detection	#1134	#1120
✅	anomaly-detection-dashboards-plugin		#662	no action needed
✅	asynchronous-search	#521	#515
✅	common-utils	#581	#579
✅	cross-cluster-replication	#1298	#1310
✅	custom-codecs		#92	no action needed
✅	data-prepper	#3869	#3978
✅	dashboards-observability	#1296	#1371
✅	dashboards-visualizations		#308	no action needed
✅	docker-images			archived
✅	documentation-website	#5887, #6058, #6279	#5946
✅	flow-framework		#310	no action needed
✅	geospatial	#616	#615
✅	helm-charts	#518	#515
✅	index-management	#1076	#1064
✅	index-management-dashboards-plugin	#954	#957
✅	job-scheduler		#553	no action needed
✅	k-NN	#1415	#1359
✅	logstash-input-opensearch	#55	#56
✅	ml-commons		#1899	no action needed
✅	ml-commons-dashboards		#292
✅	neural-search	#551	#550
✅	notifications		#832	no action needed
✅	opensearch-build	#4302	#4303
✅	opensearch-cluster-cdk	#86
✅	OpenSearch-Dashboards	#5736	#5636
✅	opensearch-dashboards-functional-test	#981
✅	opensearch-k8s-operator	#692	#703	no action neede
✅	opensearch-net	#480	#520
✅	opensearch-net-abstractions			archived
✅	opensearch-php		#172	no action needed
✅	opensearch-py-ml	#365	#371
✅	opentelemetry-demo	#114	#113
✅	performance-analyzer		#613	no action needed
✅	performance-analyzer-rca	#526	#527
✅	reporting		#938	no action needed
✅	search-processor	#214	#216
✅	security	#3844
✅	security-analytics	#832	#831
✅	security-dashboards-plugin	#1696
✅	sql-cli	#25	#26
✅	sql-odbc		#65	no action needed

Answer 1 · 2023-10-30T19:07:17.000Z

[Triage] This is a meta tracking issue for replacing default credential usage in the cluster.

Answer 2 · 2023-12-12T19:59:05.000Z

Relevant line in opensearch-build repo: https://github.com/opensearch-project/opensearch-build/blob/main/scripts/default/integtest.sh#L92

Answer 3 · 2023-12-13T15:27:10.000Z

CI references to admin:admin :https://github.com/search?q=org%3Aopensearch-project+admin%3Aadmin&type=code&p=1

Answer 4 · 2023-12-13T16:02:34.000Z

https://github.com/search?q=org%3Aopensearch-project+admin%3Aadmin+repo%3Aopensearch-project%2Fopensearch-js&type=code&p=1, solved by: opensearch-project/opensearch-js#669

Answer 5 · 2023-12-13T22:30:53.000Z

opensearch-project/alerting-dashboards-plugin#849

Answer 6 · 2023-12-13T22:36:20.000Z

opensearch-project/index-management-dashboards-plugin#954

Answer 7 · 2023-12-15T21:56:43.000Z

What version of OpenSearch will have the new password? Data Prepper actually has quite a few occurrences of the password admin. Search for password=admin, password: admin, password: "admin".

Answer 8 · 2023-12-15T22:25:30.000Z

@dlvenable it will be for version 2.12 and above

Answer 9 · 2023-12-18T18:54:59.000Z

opensearch-project/sql-cli#25

Answer 10 · 2023-12-18T19:10:51.000Z

opensearch-project/reporting-cli#56

Answer 11 · 2023-12-18T20:21:58.000Z

opensearch-project/cross-cluster-replication#1298

Answer 12 · 2023-12-18T20:32:39.000Z

opensearch-project/terraform-provider-opensearch#138

Answer 13 · 2023-12-18T21:33:54.000Z

opensearch-project/opensearch-ruby#217

Answer 14 · 2023-12-18T21:37:39.000Z

opensearch-project/opensearch-rs#234

Answer 15 · 2023-12-18T21:43:20.000Z

opensearch-project/opensearch-go#449

Answer 16 · 2023-12-18T23:06:49.000Z

opensearch-project/project-website#2501

Answer 17 · 2023-12-18T23:17:12.000Z

Most references in this repo: seem to disable install demo config: https://github.com/opensearch-project/opensearch-benchmark/blob/main/osbenchmark/resources/docker-compose.yml.j2#L18, I don't think we need to do anything for this repo, but maybe we should make an issue and tag maintainers.

Answer 18 · 2023-12-18T23:22:19.000Z

Edit: opensearch-project/opensearch-build-libraries#357

Answer 19 · 2023-12-19T15:53:00.000Z

https://github.com/opensearch-project/opensearch-php/actions/runs/7250326156/job/19750248987 - opensearch-php is running without security it seems like, so no changes necessary

Answer 20 · 2023-12-21T18:47:09.000Z

opensearch-project/opensearch-build#4302 - this means that all repos which still need to maintain their own integtest.sh files should be switching to admin:myStrongPassword123! as new default creds

Answer 21 · 2023-12-27T17:15:50.000Z

opensearch-project/opensearch-php#172

Answer 22 · 2023-12-28T18:26:58.000Z

opensearch-project/opensearch-migrations#480

Answer 23 · 2023-12-28T18:47:17.000Z

opensearch-project/sql-odbc#65

Answer 24 · 2024-01-04T17:02:32.000Z

[1/4/2024] Current status:

PRs we are blocked for reviews on (build related):

opensearch-project/opensearch-build-libraries#357 (Blocked on rpm/deb decision)
opensearch-project/helm-charts#504 (blocked on review)
opensearch-project/helm-charts#503 (blocked on review)
opensearch-project/terraform-provider-opensearch#138 (in progress)
opensearch-project/opensearch-build#4302 (in progress)
opensearch-project/opensearch-build#4250 (blocked on review)
opensearch-project/opensearch-build#4274 (blocked on review)
opensearch-project/opensearch-k8s-operator#692 (blocked on review)

Other PRs we should merge before 2.12.0 release (plugins):

opensearch-project/opensearch-dashboards-functional-test#981 (In progress)
opensearch-project/cross-cluster-replication#1298 (In progress)

All other PRs in this meta will be turned into draft and merged in after release (ETA: EOD today, 1/4/2024)

Answer 25 · 2024-01-10T14:45:12.000Z

[1/10/2024]

PRs blocked on reviews:

Decision on RPM/DEB : opensearch-project/opensearch-build#4332

Answer 26 · 2024-01-18T17:53:20.000Z

adding @bbarani to keep this in his radar

Answer 27 · 2024-01-18T20:42:01.000Z

Right now we have 27 non-compliant/unknown issues

Answer 28 · 2024-01-22T15:57:33.000Z

Right now we have 27 non-compliant/unknown issues

This number is down to 22 now.

Answer 29 · 2024-01-23T00:37:08.000Z

For AD:
pr for addressing anomaly-detection: opensearch-project/anomaly-detection#1134
For AD-Dashboard:
No action needed as there's no reference of using the admin:admin credential

Please help updating AD and AD-Dashboard status in the Task sheet in the issue description above (I cannot edit it..

Answer 30 · 2024-01-23T19:29:25.000Z

Please help updating AD and AD-Dashboard status in the Task sheet in the issue description above (I cannot edit it..

Already updated.

Answer 31 · 2024-01-23T21:30:28.000Z

Please help updating Neural Search status in the Task sheet in the issue description above (I cannot edit it.)

cc: @DarshitChanpura

Answer 32 · 2024-01-24T15:45:54.000Z

[Update: 01/24/'24]

Status	Count
Will be merged post release ⌛	10
In Progress 🕐	8
No updates ❌	11
Complete ✅	21

Answer 33 · 2024-01-25T17:17:23.000Z

[Update: 01/25/'24]

Status	Count
Will be merged post release ⌛	10
In Progress 🕐	11
No updates ❌	5
Complete ✅	24

Answer 34 · 2024-01-26T17:43:31.000Z

[Update: 01/26/'24]

Status	Count
No updates ❌	2
In Progress 🕐	7
Will be merged post release ⌛	9
Complete ✅	32

Answer 35 · 2024-01-29T16:33:58.000Z

[Update: 01/29/'24]

Status	Count
No updates ❌	2
In Progress 🕐	8
Will be merged post release ⌛	9
Complete ✅	32

Answer 36 · 2024-01-30T18:20:55.000Z

[Update: 01/30/'24]

Status	Count
❌ No updates	2
🕐 In Progress	7
⌛ Will be merged post release	9
✅ Complete	33

Answer 37 · 2024-01-31T15:27:28.000Z

[Update: 01/31/'24]

Status	Count
❌ No updates	2
🕐 In Progress	6
⌛ Will be merged post release	10
✅ Complete	33

Answer 38 · 2024-02-01T17:07:02.000Z

[Update: 02/01/'24]

Status	Count
❌ No updates	1
🕐 In Progress	4
⌛ Will be merged post release	10
✅ Complete	36

Answer 39 · 2024-02-02T17:05:49.000Z

[Update: 02/02/'24]

Status	Count
❌ No updates	1
🕐 In Progress	4
⌛ Will be merged post release	10
✅ Complete	37

Answer 40 · 2024-02-05T15:39:19.000Z

[Update: 02/05/'24]

Status	Count
❌ No updates	1
🕐 In Progress	5
⌛ Will be merged post release	10
✅ Complete	37

Answer 41 · 2024-02-06T15:44:52.000Z

[Update: 02/06/'24]

Status	Count
❌ No updates	0
🕐 In Progress	2
⌛ Will be merged post release	9
✅ Complete	42

Answer 42 · 2024-02-07T18:01:59.000Z

[Update: 02/07/'24]

Status	Count
❌ No updates	0
🕐 In Progress	2
⌛ Will be merged post release	9
✅ Complete	42

Answer 43 · 2024-02-08T15:09:34.000Z

[Update: 02/08/'24]

Status	Count
❌ No updates	0
🕐 In Progress	0
⌛ Will be merged post release	11
✅ Complete	42

Answer 44 · 2024-02-09T15:59:51.000Z

Next update will be post 2.12 release. This task is no longer a blocker for 2.12

Answer 45 · 2024-02-22T21:37:23.000Z

[Update: 02/22/'24]

Status	Count
❌ No updates	0
🕐 In Progress	0
⏳ Will be merged post release	9
✅ Complete	44

This is the last update on this issue. The maintainers of PRs with ⏳ status have been nudged to bring this across the finish line. Closing this as the feature has been delivered in 2.12.