New OpenStreetMap Carto release, v4.24.0
jeisenbe opened this issue · 11 comments
A new version of OpenStreetMap Carto, v4.24.0 (https://github.com/gravitystorm/openstreetmap-carto/releases/tag/v4.24.0), has been released.
There are no major changes required
Please wait with a deployment, it seems like we have some misunderstanding regarding one of the biggest changes.
Probably ref gravitystorm/openstreetmap-carto#3930 (comment)
Is this a significant enough issue to prevent deployment? I believe the concern in gravitystorm/openstreetmap-carto#3930 (comment) is a matter of opinion. It is not than a serious bug which would impact usability for mappers or map users.
It's a blocker for me.
I gave my long comment and proposition of what to do next here: gravitystorm/openstreetmap-carto#3930 (comment). Reverting one change might be made quite fast, if you insist on fast deployment.
It's a blocker for me
This statement, and the comments in gravitystorm/openstreetmap-carto#3930 (comment) are statements of opinion, based on subjective dislike of "water borders are sharp", which is a basic feature of the OpenStreetMap data model and Openstreetmap-Carto's method of representing features in a way that shows the underlying data clearly.
It is incorrect to suggest that release v4.24.0 is not ready for deployment.
It's one thing to misunderstand (it's a human thing I can undertand) and the other to push this error further down the line when you're aware of this, it undermines my faith that this is done in a good faith.
I believe making half baked big changes "just for a test" (?) is a disservice for the users. Could you please explain why you need the deploy to happen exactly right now?
representing features in a way that shows the underlying data clearly.
I don't believe it's that simple. What about rendering exact (thin) lines for rivers and roads instead of areas?
I am not trying to do anything in bad faith or make any changes for which there is no consensus.
Based on the recent comments, I understood that we had consensus on merging the changes in #3930.
The new issue is whether additional changes need to be made before a release to further improve the esthetic appearance.
That does not appear to be a sufficient reason to revert the change or the delay the release, in my opinion.
But I think we should discuss this with the other contributors to Openstreetmap-Carto at gravitystorm/openstreetmap-carto#3939 and come to an agreement there.
Based on the recent comments, I understood that we had consensus on merging the changes in #3930.
The consensus was just on the principle (this is exactly what you have asked), not the actual code. You just misunderstood then that we agree on the code. This does not change the lack of consensus then and now.
The new issue is whether additional changes need to be made before a release to further improve the esthetic appearance.
My last comment was not about esthetics:
it becomes more important that people don't see artificial strong lines if they decide the line should be long. They should be not pushed by visual solution which is suitable only for small borders (and even then it's inferior).
https://github.com/gravitystorm/openstreetmap-carto/releases/tag/v4.24.1 - v4.24.1 is now released, resolving the concerns above.