openwallet-foundation/bifold-wallet

The unlock button shuld not be active unless all 6 PIN digits are entered

jleach opened this issue · 3 comments

jleach commented

Description of problem

You can press the "unlock" button on the pin PIN screen with any number of digits.

Expected behavior

Since 6 are required, it should wait for all 6 to be input before becoming active.

Steps to reproduce

At the "Enter PIN" screen, press the unlock button.

Screenshots and/or log output

Environment

  • Occurs on Android
  • Occurs on iOS

Build #:

Android Device Model:

iOS Device Model:

Workaround

Severity

  • High
  • Medium
  • Low

I think it's fine the way it is. Its a little extra security. If someone knew the passcode, they'd know its a 6 digit number. If they didn't know, then they'd try any number of digits. We'd want to count each attempt to ensure its locked if too many attempts were made.

Also. trying to avoid disabled buttons because as a principle, people need to know why they can't press a button and a disabled state of a button doesn't inform people on why they can't click on it.

resolved by: #1017

This can be closed. Tested in 1279. I don't have access to close in this repo.