opynfinance/squeeth-monorepo

Issues

• Natspec/comments review + improvements

  #474 opened 2 years ago by aleone
  0

• Fix 1wei diff issue in test

  #696 opened 2 years ago by haythemsellami
  0

• Update crab accounting to burn a min amount of liquidity on initial deposit and have min amount of deposit

  #670 opened 2 years ago by aleone
  0

• Potential Minor Gas Savings

  #561 opened 3 years ago by AlphaSerpentis
  0

• Crab Position Value can be off by up to `2 * priceHedgeThreshold` (currently +-40%)

  #519 opened 3 years ago by llllvvuu
  0

• Allow users to go short even if they have some long position and vice versa by changing hard block into overrideable warning

  #507 opened 3 years ago by alexisgauba
  0

• Fix interface pulling ropsten data on mainnet and mainnet data on ropsten

  #479 opened 3 years ago by EstherSeyi
  0

• RebalanceVaultNft - DecreaseLpLiquidity along with DepositIntoVault will often fail

  #491 opened 3 years ago by aleone
  0

• BurnExactRemoved flag in rebalanceNftVault() fails at times

  #492 opened 3 years ago by aleone
  0

• Quantity output rather than limit price for generalSwap?

  #459 opened 3 years ago by alpinechicken
  0

• Refund for address(this).balance > 0 not reached in ControllerHelper

  #452 opened 3 years ago by alpinechicken
  1

• change way that getAmountsToLp is returned in rebalanceWithoutVault()

  #484 opened 3 years ago by aleone
  0

• Hardcoded uniswap pool in a few places

  #481 opened 3 years ago by aleone
  1

• Naming improvements

  #473 opened 3 years ago by aleone
  2

• Update DataTypes for consistency

  #475 opened 3 years ago by aleone
  0

• Naming for ControllerHelperDataType

  #443 opened 3 years ago by alpinechicken
  0

• flashswapWBurnBuyLong() will fail if user set a poolFee different than the fee of the pool stored in the diamond storage

  #441 opened 3 years ago by haythemsellami
  0

• Remove diamond storage from ControllerHelper

  #440 opened 3 years ago by haythemsellami
  0

• FLASH_W_BURN returns oSQTH to user, but doesn't need to as it is done later in sendBack()

  #471 opened 3 years ago by aleone
  0

• Change sendBack() to send ETH as the last step

  #468 opened 3 years ago by aleone
  1

• Is declaring interfaces repeatedly in line cheaper vs declaring it in memory and using it repeatedly or having it in storage

  #469 opened 3 years ago by aleone
  1

• General swaps will often fail if trying to do exact oSQTH or ETH withdrawn swaps

  #435 opened 3 years ago by aleone
  0

• For an existing vault w flashloanWMintDepositNft, we withdraw collat at end so a user cant use vault collateral for LPing

  #399 opened 3 years ago by aleone
  3

• flashswapSellLongWMint() will fail if user set a poolFee different than the fee of the pool stored in the diamond storage

  #442 opened 3 years ago by haythemsellami
  0

• increaseLpLiquidity in ControllerHelperUtil using collateralToDeposit instead of wethAmountToLP

  #446 opened 3 years ago by alpinechicken
  0

• batchMintLp vs flashloanWMintDepositNft - flashloan case can withdraw collateral from the vault while batchMintLp can't

  #398 opened 3 years ago by aleone
  1

• CloseShortWithUserNft and FlashloanCloseVaultLpNftParam taking LP liquidity as param

  #457 opened 3 years ago by alpinechicken
  0

• FlashloanWMintDepositNftParams non-standard naming

  #458 opened 3 years ago by alpinechicken
  0

• flashswapWBurnBuyLong() doesn't let a user without a vault (ie vault 0) buy oSQTH without burning

  #472 opened 3 years ago by aleone
  0

• Doesn't support trading in potential oSQTH/USD pools

  #470 opened 3 years ago by aleone
  0

• Short open liquidation price

  #444 opened 3 years ago by deepthinker250
  1

• On Chrome on Mac, scroll doesn't occasionally work on all pages.

  #445 opened 3 years ago by deepthinker250
  1

• Current profit threshold not calculating in strategies page

  #460 opened 3 years ago by deepthinker250
  0

• GENERAL_SWAP case unreachable in _swapCallback

  #451 opened 3 years ago by alpinechicken
  0

• Show Position value and PnL based on mid price (slot0)

  #421 opened 3 years ago by KMKoushik
  0

• Show PnL only for long users

  #423 opened 3 years ago by KMKoushik
  0

• Show tool tip near PnL with links explaining PnL

  #424 opened 3 years ago by KMKoushik
  0

• Collateral Ratio and action buttons are not hidden when selecting None for lp Token

  #419 opened 3 years ago by block902
  0

• Fe doesn't proceed to next step after an approval transaction sometimes

  #415 opened 3 years ago by yichiehliu
  0

• RebalanceVaultNft actions don't share state and can lead to suboptimal user results

  #411 opened 3 years ago by aleone
  2

• Batch request historical ETH prices

  #422 opened 3 years ago by KMKoushik
  0

• increaseLiquidity action should have a way to use the balance of the contract

  #412 opened 3 years ago by aleone
  0

• Users that want to burn the exact amount of oSQTH withdrawn from a vault may have transactions fail

  #383 opened 3 years ago by aleone
  1

• Access control not implemented for all functions

  #387 opened 3 years ago by aleone
  2

• mintAndLP returns vaultId=0

  #414 opened 3 years ago by alpinechicken
  1

• IncreaseLpLiquidity still relies on checkExcess, it should have the same logic as mint and LP functions

  #402 opened 3 years ago by aleone
  1

• FLASH_SELL_LONG_W_MINT for 0 mint amount tries to open a vault for a user, probably shouldnt

  #403 opened 3 years ago by aleone
  0

• Position card going blank and position page not updating on opening of both long and short positions

  #409 opened 3 years ago by EstherSeyi
  0

• Vault Information not loading on Positions after a successful shorting action performed on ROPSTEN

  #392 opened 3 years ago by DemolaJames
  1

• MintAndLp doesn't handle the case of withdrawing liquidity and then trying to LP correctly

  #401 opened 3 years ago by aleone
  0