ory/ladon

Import of testing package

Closed this issue · 5 comments

yukels commented

You import the testing package in the manager_test_helper.go file

As a result any program which is using the flag standard package and depends on the ladon library with produce many extra flags:

-test.bench string
        regular expression to select benchmarks to run
-test.benchmem
        print memory allocations for benchmarks
-test.benchtime duration
        approximate run time for each benchmark (default 1s)
-test.blockprofile string
        write a goroutine blocking profile to the named file after execution

Please slip the testing code from the production one

aeneasr commented

Wow, I did not know that that could be an issue! We should probably move this to a separate directory :) Contributions welcome!

yukels commented

Hi, do you plan to add the fix to the next release?

aeneasr commented

I am unfortunately very busy and do not have time to fix this, but as I said in the previous comment, you are more than welcome to create a PR to resolve this!

yukels commented
aeneasr commented

I am closing this issue as it has not received any engagement from the community or maintainers in a long time. That does not imply that the issue has no merit. If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you to anyone who participated in the issue! 🙏✌️