ostreifel/wiql-editor

Save button doesn't work on replatformed query page

milemons opened this issue · 10 comments

Describe the bug
When the new preview is turned on (turn on preview "New Boards Hubs"), there is an issue saving the query. Somehow the callback argument is lost

Environment:

  • Browser [e.g. chrome, edge]: Crhome
  • onpremises (Azure Devops Server/tfs) or hosted (Azure Devops): Both

Screenshots
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to a queries page that has the extension installed
  2. Turn on New Boards Hub preview in the preview panel
  3. Click on the header ... to select "Edit WIQL" extension
  4. Click "Save Query" in the wiql editor
  5. See error

Expected behavior
The query should save properly

Additional context
n/a

I tried to repro this but when I enable the "New boards Hubs" slider the queries page doesn't load anymore.

We have released a fix for that issue & it is slowly rolling out. In the meantime, you can get around it by turning off bundling (can provide steps in the morning)

Steps to turn off bundling:

  1. Go to azure devops project you would like to test on
  2. Open up chrome dev tools
  3. Go to the console and copy/paste document.cookie="TFS-BUNDLING=disabled". Hit enter
  4. Reload the page - you should see a black bar at the bottom of the page
  5. Click on "Settings" in the bottom right
  6. Disable bundling / verify bundling is disabled
  7. Queries page should load

It looks like the proxy logic that the extension is relying upon is removing data that the extension is trying to pass through.

image
image
Specifically this call in the queryEditor is trying to pass a callback to the code that manages the dialog state but the proxy logic for functions is removing the property that contains the callback.

image

Has there been a recent change in the sdk logic that handles the arguments passed to and from proxy functions that could be causing this regression?

Does anyone here know how to rollback to the old UI of azure?
@ostreifel are you using the new interface of Azure or the old one?
This issue has been started when I accepted the suggestion of platform to use the new UI.

@milemons @ostreifel
Curious if there's any plans to fix this.

Is there any other way to set the wiql of an existing query? I could do it from the command line, or via rest / curl -- then at least the query can be run from the UI.

This is still an issue 🤔
image

still opened :
image

I'm still getting this error as of today. I have the latest version (2.0.97) installed.

I briefly tried the suggestion above for disabling bundling, but the resulting UI was much, much slower. Also, I still got the same error message.

Edit: The issue is definitely related to the "New Boards Hubs" preview feature. When I turned it off, I could once again save queries.

image

Is there a workaround? Is there a fix coming?