[REQ] Tighten up the popover interface
Closed this issue ยท 29 comments
Thanks :)
I am almost satisfied with this, but have not made any code changes. Thoughts appreciated.
My goal was to "simplify, simplify, simplify".
Changes:
- remove extension name title
- regroup tab/window
- columns for checkbox/label/count & threshold
- remove slider
- make threshold into combo box (1,2,4,8,16,32 or edit own value)
- regroup close all tabs
- simplify/reduce number of words used
- reorder controls in XIB
Todo:
- Finalise language/wording
- Set constraints (I've removed them all)
-
Good point about making count obvious. I did have them combined earlier "Tab Count: 123" but split them. My reasoning was I wanted them to be instantly viewable when somebody does not have the badge active, a column of their own seemed the best way. But have reverted to combined for now.
-
Please make it fit for German. Let's decide constraints or auto layout after comparing your changes to above.
-
Let's iterate!
I have just changed the screen/zip above for my "final" time.
I just realised you are replying by email so you would have only seen my first attempt and none of the many edits after that. Did you see count in it's own column?
This is my preferred design:
Sorry for not going online first and thus critiquing without having seen everything. I get where you are coming from on your preferred design and agree that the counts are more obvious, but I still wonder, if we might be failing on glanceability.
I honestly don't have the answer here, I am just wondering. The more I look at your design the more I see its elegance, but I kind of would still want big numbers in this design. So ignore most everything in the below screenshot and just consider combining the large counts with your design.
Only other item to really consider is the "Close all tabs on". It'll be hard to squeeze a meaningful German label in there and thus I would want to propose dropping the buttons to the next line.
I see where you are coming from. Let's go with it.
The lack of alignment is driving me crazy ๐
But commit your changes and I will adjust ๐
Regarding close all tabs, would these make a difference to space used in German?
Close tabs, To Left, To Right
Close all tabs on, Left, Right
I see where you are coming from. Let's go with it.
The lack of alignment is driving me crazy ๐
But commit your changes and I will adjust ๐
I will work on that, they were very quick and very dirty changes. I will use your xib and work from there ;)
Regarding close all tabs, would these make a difference to space used in German?
Close tabs, To Left, To Right
Close all tabs on, Left, Right
German is a terrible language, as the verb would come at the end, but we can make it work. As I said, I'll start from your XIB and then you can align nicely. It also needs some additional tweaking on the code (more logic) - but we'll manage it!
I just pushed a commit with the updated layout and associated logic. The layout is wanting of your tender-loving-care @gingerbeardman
I need to test logic fully tomorrow, I can't help but feel that I screwed up somewhere
Yup there was one really stupid decision in there.
This case:
When the minimum tabCount wasn't met, but the windowCount was, I had previously decided to show both tabCount and windowCount to make for a nicer display. While testing it drove me bonkers, as it made no sense. I now changed it so that if both tab & window are to be shown, but tabCount isn't met, the windowCount will be shown as a superscript. that's not a great look, but it seems to make sense. The question should be, should it be superscript?
Edit: actually I don't mind, the user should know what they have set to be counted.
Leave it as is.
Just to confirm what will happen:
tabCount only - large number for tabCount
windowCount only - large number for windowCount
TabCount & Window Count - tabcount large, windowcount superscript, even if tabCount isn't shown due to threshold
So, Safari presents popover at ~ 280x240 pixels wide so it can't really be as tight as I have shown.
Now I need to figure out the right way to do autolayout constraints.
I like the new tighter layout:)
One question though - you declare different preferred content sizes? Shouldn't they be the same?
preferredContentSize = NSSize(width: 225, height: 283)
shared.preferredContentSize = NSSize(width:280, height:240)
One question though - you declare different preferred content sizes? Shouldn't they be the same?
preferredContentSize = NSSize(width: 225, height: 283)
shared.preferredContentSize = NSSize(width:280, height:240)
You know, I am so tired I did not even see the first one that I could have just changed!
New PR incoming.
It kind of bugs me that there are two columns of same-sized things but I will live with it for a while.
I have just added:
- disable left/right buttons if on first/last tab
Design: we can always iterate on this. I am starting to feel that we are in a decent place.
Feel free to remove them boxes...
Will push changes soon.
Do you get that weird, pale vertical line between the checkbox and "tabs" label? in Dark mode.
Merged
Will push changes soon.
Do you get that weird, pale vertical line between the checkbox and "tabs" label? in Dark mode.
No, I don't get that
Good, must just be a bug in Mojave to do with running a non-retina external screen.
My latest UI changes were a quick hack, I just made the boxes invisible. If we're cool with the new layout then they can be removed and I think we are pretty much "feature complete" for v1.0?