owncloud/openidconnect

[QA] admin cannot login, when basic_auth_guest_only is true

jnweiger opened this issue · 8 comments

jnweiger commented

Seen while testing openidconnect 2.2.0-rc.6 with core 10.11.0

  • Restrict basic auth to guests only: occ config:system:set openid-connect.basic_auth_guest_only --value true --type boolean
  • Try to log in the admin user with basic auth.
  • An error occurs. BAD
    image

Expected behaviour:

  • admin can always log in.
DeepDiver1975 commented

Works as designed. Only guests 🤷

DeepDiver1975 commented

I suggest to revert #253 and get this release rolling.

We have customers waiting for other features of this release.

@jvillafanez @hodyroff @jnweiger objections

jvillafanez commented

#265 would fix this, but we need to decide what to do with the feature as a whole

DeepDiver1975 commented

Absolutly

  • blocking/allowing guest login is not the responsibility of the openid connect app from my pov
  • adding yet another config switch #265 might be a bit overkill - only one customer is requesting this feature
  • lack of decision making is blocking other customers
DeepDiver1975 commented

revert pr created ...... so that we are prepares once the decision is there ..... #268

jnweiger commented

I agree with the revert and move everything to work with groups. #265 could carry guests and admin group to fix my case.
The naming of the key in #265 is weird then and should be simplified.

  • 👍2